Skip to content

Don't reset slideshow state when Settings -> Developer options is clicked#32

Merged
lsd-cat merged 1 commit intoosservatorionessuno:mainfrom
rocodes:no-flicker-on-resume
Sep 5, 2025
Merged

Don't reset slideshow state when Settings -> Developer options is clicked#32
lsd-cat merged 1 commit intoosservatorionessuno:mainfrom
rocodes:no-flicker-on-resume

Conversation

@rocodes
Copy link
Copy Markdown
Contributor

@rocodes rocodes commented Sep 4, 2025

Remove a line that force-resets the slideshow state if the user navigates to settings -> developer options that looks like it was meant for testing only.

This line can cause a glitch where if you click it but don't make any permissions changes, the app enters an unrecoverable flickering state (tries to show homepage -> tries to advance past all the pages) which can only be fixed by clearing the app's local storage in the OS.

Sidenote: this is a small fix, but I'm still working on a draft of a refactored state-based workflow for the slideshow, which will hopefully mean maintaining a lot less state in separate places: see very rough WIP at main...rocodes:bugbane:states

@TheZ3ro
Copy link
Copy Markdown
Member

TheZ3ro commented Sep 5, 2025

Nice catch!

@lsd-cat I guess builds are failing cause they require env variables that Github do not expose when non-collaborator do pull request, is that right?

I guess we can merge and see what happens 😄

@lsd-cat
Copy link
Copy Markdown
Member

lsd-cat commented Sep 5, 2025

Yep that's the issue :( the env variables are just to bring a keystore to have signing reproducible and for fdroid, but in the next iteration we can probably drop them. Will follow up with a CI ticket

@lsd-cat lsd-cat merged commit d30a0ff into osservatorionessuno:main Sep 5, 2025
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants