Don't reset slideshow state when Settings -> Developer options is clicked#32
Merged
lsd-cat merged 1 commit intoosservatorionessuno:mainfrom Sep 5, 2025
Merged
Conversation
Member
|
Nice catch! @lsd-cat I guess builds are failing cause they require env variables that Github do not expose when non-collaborator do pull request, is that right? I guess we can merge and see what happens 😄 |
Member
|
Yep that's the issue :( the env variables are just to bring a keystore to have signing reproducible and for fdroid, but in the next iteration we can probably drop them. Will follow up with a CI ticket |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove a line that force-resets the slideshow state if the user navigates to settings -> developer options that looks like it was meant for testing only.
This line can cause a glitch where if you click it but don't make any permissions changes, the app enters an unrecoverable flickering state (tries to show homepage -> tries to advance past all the pages) which can only be fixed by clearing the app's local storage in the OS.
Sidenote: this is a small fix, but I'm still working on a draft of a refactored state-based workflow for the slideshow, which will hopefully mean maintaining a lot less state in separate places: see very rough WIP at main...rocodes:bugbane:states