There is a bug still#42
Open
ayush1999guptA wants to merge 15 commits intooss2019:masterfrom
ayush1999guptA:master
Open
There is a bug still#42ayush1999guptA wants to merge 15 commits intooss2019:masterfrom ayush1999guptA:master
ayush1999guptA wants to merge 15 commits intooss2019:masterfrom
ayush1999guptA:master
Conversation
|
Hello @ayush1999guptA! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-05-23 15:09:26 UTC |
Member
|
Hehe @ayush1999guptA I had a problem with email validation too, and I understand. I really do suggest you use pycharm with pep8 installed, it really helps you write clean pep8 code fast. I'll review this soon. |
Member
Author
|
I fixed the pep8 issues |
svp19
requested changes
May 22, 2019
Member
There was a problem hiding this comment.
- You'll have to pre-populate the edit form with old profile values so that we don't have to re-enter every field each time we want to edit it. To do this just pass profile instance while you instantiate the UserEditForm.
- Also you'll have to pass request.FILES to make sure the image can be uploaded
Eg: form = UserEditForm(request.POST, request.FILES, instance=request.user.profilemodel)
- Additionally, you may want to rename the form to
ProfileEditFormjust so that there are no confusions later. - PEP8 Fixes look great!
- refer https://www.youtube.com/watch?v=CQ90L5jfldw&list=PL-osiE80TeTtoQCKZ03TU5fNfx2UY6U4p&index=9 if you get stuck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-[ ] Closes: #31
-[ ] Closes: #21
-[x] PEP8
Changes Summary: created a user profile render thingy, there is still a bug I can't sort is that it is not able to fetch media files. I removed email validation as it was very uncertain. I worked very hard on this ,I better get the t-shirt :)