-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wasm collaboration network first pass #228
Conversation
project velocity discussion
add dashboard demo and bug fix
file reorganization
adds utility of joining two or more repo networks in the context of some general WASM projects, suggests next steps for improvement. Signed-off-by: James Kunstle <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:41Z How/why did you choose the set of repos? Was 5 a specific choice? JamesKunstle commented on 2023-09-19T14:44:58Z No it was arbitrary. This notebook isn't really trying to be experimental, just demonstrate the technique of combining networks, so I picked a few preeminent projects within scope. cdolfi commented on 2023-09-20T17:52:24Z got it |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:43Z What does a node represent here? JamesKunstle commented on 2023-09-19T14:45:24Z ++ need to clarify this. |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:44Z the JamesKunstle commented on 2023-09-19T14:45:34Z ++ |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:45Z Line #3. ("wasmtime", "bytecodealliance"), Why is wasi not included? JamesKunstle commented on 2023-09-19T14:46:14Z wasi was failing for some reason so I just removed it for consideration. cdolfi commented on 2023-09-20T17:54:18Z Makes sense, lets open an issue to look into this to see why/ make sure there is nothing bigger happening w that repos data |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:45Z Plotly? JamesKunstle commented on 2023-09-19T14:46:51Z Yeah the backend draws in Plotly. |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:47Z same comment for the image below, also can the legend be included in the photo? JamesKunstle commented on 2023-09-19T14:47:23Z ++ cdolfi commented on 2023-09-20T17:55:09Z Can you add the legend to the picture? JamesKunstle commented on 2023-09-20T18:28:44Z Adding a legend is actually a really complicated process for this many nodes, unfortunately, so I'd rather make a note and merge this PR than spend the time hacking the legend in- are you amenable to that? cdolfi commented on 2023-09-20T19:03:11Z Sounds good to me! |
View / edit / reply to this conversation on ReviewNB cdolfi commented on 2023-09-14T14:51:48Z Can you import the photos into the notebook so they are shown ? Also include the legend, not sure exactly what I am looking at example from the key_mgmt notebook img = 'keylime_company.png' Image(filename=img) JamesKunstle commented on 2023-09-19T14:47:13Z ++ Yeah definitely |
No it was arbitrary. This notebook isn't really trying to be experimental, just demonstrate the technique of combining networks, so I picked a few preeminent projects within scope. View entire conversation on ReviewNB |
++ need to clarify this. View entire conversation on ReviewNB |
++ View entire conversation on ReviewNB |
wasi was failing for some reason so I just removed it for consideration. View entire conversation on ReviewNB |
Yeah the backend draws in Plotly. View entire conversation on ReviewNB |
++ Yeah definitely View entire conversation on ReviewNB |
++ View entire conversation on ReviewNB |
Signed-off-by: James Kunstle <[email protected]>
@cdolfi updated PR |
got it View entire conversation on ReviewNB |
Makes sense, lets open an issue to look into this to see why/ make sure there is nothing bigger happening w that repos data View entire conversation on ReviewNB |
Can you add the legend to the picture? View entire conversation on ReviewNB |
@JamesKunstle only small comments left on my side. @hemajv @oindrillac would yall be able to review as well? |
Adding a legend is actually a really complicated process for this many nodes, unfortunately, so I'd rather make a note and merge this PR than spend the time hacking the legend in- are you amenable to that? View entire conversation on ReviewNB |
Sounds good to me! View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB oindrillac commented on 2023-09-21T13:08:22Z Do the edges represent an existence of a relationship or are they also weighted by the number of contributions? I think both are significant. If it is the former, maybe we want to also explore the latter at some point? hemajv commented on 2023-09-21T20:05:00Z How are we defining the communities here? JamesKunstle commented on 2023-09-22T20:54:21Z replaced 'community' with 'repo' |
View / edit / reply to this conversation on ReviewNB oindrillac commented on 2023-09-21T13:08:23Z This is awesome work! Thank you @JamesKunstle, @mariashev
I know that this work is not tied to a hypothesis, I would like us to "prove out this hypothesis" at some point, by running this on a possibly known set of linchpin contributors - I describe an example here https://github.com//issues/200 It would be interesting to identify that list of critical members algorithmically and also contributors who are beyond this list but serve as linchpins.
JamesKunstle commented on 2023-09-22T20:54:44Z ++ sounds great |
How are we defining the "communities" here? View entire conversation on ReviewNB |
View / edit / reply to this conversation on ReviewNB hemajv commented on 2023-09-21T20:08:49Z Small typo:
If I understand correctly, after merging the networks the final network should have contributors as the nodes right? JamesKunstle commented on 2023-09-22T20:45:20Z Yes exactly. The nodes of the merged network are the union of the nodes of the two networks. |
View / edit / reply to this conversation on ReviewNB hemajv commented on 2023-09-21T20:08:50Z Can you also include a brief markdown explaining what this function does? |
View / edit / reply to this conversation on ReviewNB hemajv commented on 2023-09-21T20:08:51Z any reason we chose the start year as 2017? Perhaps, worthwhile to mention it here as well |
@JamesKunstle @mariashev great work on the collaboration network analysis 🎉 |
Yes exactly. The nodes of the merged network are the union of the nodes of the two networks. View entire conversation on ReviewNB |
replaced 'community' with 'repo' View entire conversation on ReviewNB |
++ sounds great View entire conversation on ReviewNB |
Signed-off-by: James Kunstle <[email protected]>
@hemajv @oindrillac @cdolfi responded to PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Good to merge once oindrilla and hema take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks @JamesKunstle
@JamesKunstle : I'm running your fork and get an error that this notebook does not exist: |
@sgoggins uhhhh weird. I'll look into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the comments @JamesKunstle!
/lgtm 👍
@sgoggins I definitely don't get that error. Are you getting it when you boot this notebook and try to run it? |
adds utility of joining two or more repo networks in the context of some general WASM projects, suggests next steps for improvement.