Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The searchbar has always been a bit painful in our app because we drove it with the backend- each key press registered as an HTTP request to the app server, and the updated search results were returned.
In this setup, we send ALL options to the frontend and let the React MultiSelect component handle search for us.
This should minimize the weird search behavior of orgs being duplicated and repos not being entered correctly.
I also took this opportunity to think through how we could reorganize our interfaces to Augur, unpacking the AugurManager object and creating a new MSOptionsHandler object ("MultiSelect Options Handler") that replaces the searchbar features that used to be in the AugurManager.
next step is to handle user groups in this same way, likely with a second, optional multiselect bar that is enabled when the user is logged in.
I'd also like to consider having Repos and Orgs in separate search bars, and discouraging querying for entire orgs by putting orgs behind a dropdown (MOST of the time looking at the entire org isn't necessary).