Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined Directory Structure and added functionalties #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vinay0410
Copy link
Contributor

@vinay0410 vinay0410 commented Oct 14, 2018

Hi @codebot ,

  • Shift Redundant code to training placeholder directory
  • Added launch file for cv_camera ( usb cam doesn't work on MacOS )
  • Vision msgs can now be installed from debian packages sudo apt install ros-<distro>vision-msgs. Therefore, changed readme for that.
  • Option to select different model by changing params in the launch file. This would prevent users from altering the code, and if this package is released then it would be better to change launch file rather than code.
  • Model will be only downloaded if user doesn't provide model path, Earlier it was being downloaded anyways while running cmake.
  • Better Error and info logging

Update:

Thanks!
Any feedback on the same would be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Centroid calculus
1 participant