Add IPC support to RockerExtension #284
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new IPC class that extends RockerExtension to handle IPC namespace options. - Implemented `get_name` to return the 'ipc' identifier. - Added `get_docker_args` method to generate Docker IPC arguments based on CLI input. - Included a `get_preamble` method that returns an empty string as no preamble is needed. This commit enables the use of IPC-related Docker arguments in Rocker configurations.
Add IPC support to RockerExtension
|
Closing this PR, because I wanted to create PR from a branch instead of main branch. PR #285 is the final PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_nameto return the 'ipc' identifier.get_docker_argsmethod to generate Docker IPC arguments based on CLI input.get_preamblemethod that returns an empty string as no preamble is needed.This PR enables the use of IPC-related Docker arguments in Rocker configurations and should close the issue #241.