Support SQLAlchemy 2.0 with sqlalchemy-oso
#1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gj
approved these changes
Jun 11, 2024
.github/workflows/test.yml
Outdated
There was a problem hiding this comment.
Pinning Rust: yes, the other ones no
| @@ -118,7 +118,6 @@ def test_get_column_entities(stmt, o): | |||
| (select(A), set()), | |||
| (select(A).options(joinedload(A.bs)), {B}), | |||
| (select(A).options(joinedload(A.bs).joinedload(B.cs)), {B, C}), | |||
| (select(A).options(Load(A).joinedload("bs")), {B}), | |||
There was a problem hiding this comment.
This is an invalid way of calling it in 2.0
Comment on lines
+624
to
+627
| if USING_SQLAlchemy_v2_0: | ||
| tables = "tags, post_tags" | ||
| else: | ||
| tables = "post_tags, tags" |
There was a problem hiding this comment.
what in the world– why does this order matter???
There was a problem hiding this comment.
It matters because we do a string comparison of the SQL we get back. SQLAlchemy 2.0 reordered these a little. We have this pattern elsewhere.
Would be nice if we had snapshots like with insta!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for sqlalchemy 2.0