Conversation
|
Can you tell me more about the single vs. double quote change? They are equivalent in HTML, so I'm wondering what issue you are seeing. If we're going to change quoting style, we should change them all and probably in a separate PR so that it doesn't distract from other changes. |
I would have assumed that as well. The Aria subsystem is likely more rigorous than normal HTML. This would explain why most accessible tools ignore tags that don't use double quotes, leading to failed requirements. I would be more than happy to submit a separate PR to convert everything to a double quote |
|
Can we change this PR to only be the accessibility changes (not quote changes) and see if the desired accessibility features work with just that change? |
|
That was the first thing I tried that. This browsers and accessibility
checkers seem to require double quotes for all the tags involved for the
features to work correctly.
…On Mon, Apr 22, 2024, 6:49 PM Ian Dees ***@***.***> wrote:
Can we change this PR to only be the accessibility changes (not quote
changes) and see if the desired accessibility features work with just that
change?
—
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIGQRF3SPOPUL7EY6YSJVLY6WHY7AVCNFSM6AAAAAA7KFKNF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZRGA4DAMBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Waiting for merge or further comments |
|
Can you share what accessibility checkers you were using that care about quotes? |
|
I used Wave, Axe, and Silktide. The quotes were a bit of a red herring. I also found that many more things need to be changed to be accessible. For now, the site has a simple structure so keyboard users can do basic navigation. It can also use the translated strings for labels and placeholders. I reverted all the single to double quotes. |
|
Sorry, this PR is quite hard to review because there's other stuff in the change. Are all the changes in here related to accessibility? Looks like there's some localization updates too? |
|
The only other commits are those pulled in from main.
…On Mon, Jul 8, 2024, 2:36 PM Ian Dees ***@***.***> wrote:
Sorry, this PR is quite hard to review because there's other stuff in the
change. Are all the changes in here related to accessibility? Looks like
there's some localization updates too?
—
Reply to this email directly, view it on GitHub
<#131 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIGQRCX27J6M4JF537JX5LZLLLZDAVCNFSM6AAAAAA7KFKNF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJUHEYDQOJUGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
2 participants
Added basic landmarks to page. Includes named divs and translations. Also converted single to double quotes so exists IDs would be recognized by the browser. Added fail-back text that will be used as aria-label in case translation fails to load.