Skip to content

fix: broken links and metadata for europe/no sources#2896

Merged
andrewharvey merged 11 commits intoosmlab:gh-pagesfrom
Johannes-Andersen:fix/noMeta
Mar 3, 2026
Merged

fix: broken links and metadata for europe/no sources#2896
andrewharvey merged 11 commits intoosmlab:gh-pagesfrom
Johannes-Andersen:fix/noMeta

Conversation

@Johannes-Andersen
Copy link
Copy Markdown
Contributor

@Johannes-Andersen Johannes-Andersen commented Jan 31, 2026

Apologies for the massive PR 😅

This PR should't touch any "service" relates settings, like url, zoom, geometry, etc. 
Change of plan due to tests failing causing the PR to get ❌ . Fixed the failing endpoints to get tests passing for this PR

What this PR aims to fix:

  • Add missing license_url
  • Update license_url to not use redirecting URLs
  • Update since deleted mailing list URLs to use archived links (until we get something better)
  • Update privacy_policy_url to go to correct pages
  • Rename Oljedirektoratet -> Sokkeldirektoratet after they changes name
  • Correct attribution (URLs 404ing, redirecting and missing required)
  • Fix 404 icon links, and icons hitting weird third party sites

Related PRs:

@Johannes-Andersen
Copy link
Copy Markdown
Contributor Author

Johannes-Andersen commented Jan 31, 2026

Should be ready for review now 😄

Web archive is a bit unstable. Think we need to live with it for now, and maybe reach out to get a more up to date approval

ERROR:root:sources/europe/no/gridVoltagesOwnersOverlay.geojson: license url https://web.archive.org/web/20240114010212/https://lists.nuug.no/pipermail/kart/2017-December/006312.html is not reachable: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))

@andrewharvey andrewharvey merged commit 1f3c8f9 into osmlab:gh-pages Mar 3, 2026
1 check failed
naterkane pushed a commit to naterkane/editor-layer-index that referenced this pull request Mar 5, 2026
* fix: broken links and metadata for europe/no sources

* fix: NPI logo

* fix: correct wms version and add another missing privacy_policy_url

* fix: failing npd and sse endpoints

* fix: KartverketNauticalCharts url

* chore: minor min/max zoon and new nve.no url

* chore: split NVE changes into own PR

* chore: split SSB into smaller PR

* chore: fix coordinates

* chore: attempt to fix geometry

* fix: use different icon for NPI due to Cloudflare WAF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants