Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix konsole dbus call and modify xsettingsd on kde as a fallback method #260

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Fix konsole dbus call and modify xsettingsd on kde as a fallback method #260

merged 5 commits into from
Jan 16, 2024

Conversation

heddxh
Copy link
Contributor

@heddxh heddxh commented Jan 13, 2024

  • Konsole seems don't split it sessions so it may can directly switch theme by calling set_profile
  • Kde user may not install kde-gtk-config. In this case their gtk apps may be controlled by xsettingsd.

l0drex
l0drex requested changes Jan 14, 2024
View reviewed changes
Copy link
Collaborator

@l0drex l0drex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I have some minor requests, other then that it looks good!

tests/test_plugins.py Outdated Show resolved Hide resolved
yin_yang/__main__.py Outdated Show resolved Hide resolved
yin_yang/plugins/kvantum.py Outdated Show resolved Hide resolved
yin_yang/plugins/gtk.py Show resolved Hide resolved
yin_yang/plugins/konsole.py Show resolved Hide resolved
@heddxh
Copy link
Contributor Author

heddxh commented Jan 14, 2024

Sorry I forgot push to my fork will also affect my pr.
I will clean my code!

@heddxh heddxh marked this pull request as draft January 15, 2024 11:41
@heddxh heddxh marked this pull request as ready for review January 16, 2024 11:42
@heddxh heddxh requested a review from l0drex January 16, 2024 11:43
l0drex
l0drex approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@l0drex l0drex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@l0drex l0drex merged commit 1d5c01c into oskarsh:master Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0drex l0drex l0drex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heddxh @l0drex