Remove dead code from declarative property lookup 馃 - #3116
Open
lwrage wants to merge 1 commit into
Open
Conversation
Let feature groups use the existing Feature dispatch, which already reaches the inherited lookup implementation. Remove the uncalled equivalent helper and the empty null check so the declarative lookup path contains only behaviorally distinct cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FeatureGroupbranch from declarative-model property lookup. Feature groups now reach the same inheritedFeatureImpl.getPropertyValueimplementation through the followingFeaturebranch.FeatureGroupImpl.getPropertyValueTestHelper, which has no repository caller and duplicates the inherited lookup behavior.compDecls == nullblock and its stale FIXME.This is intentionally a behavior-preserving cleanup. No new regression test was added because none of the removed code could produce distinct behavior; the existing property lookup and caching tests were run before and after the change.
Fixes #3107
Validation
Focused pre-change and post-change validation:
Both runs passed 4 tests with no failures, errors, or skips.
Clean root validation:
All 137 reactor projects succeeded. Surefire reports contained 1,429 tests with no failures, errors, or skips.
Dependencies and residual risk
There are no dependent PRs; the branch is based directly on current
masterat7729ae9476.Removing the public
FeatureGroupImpl.getPropertyValueTestHelpermethod is binary-incompatible for an external caller of the exported implementation package. A repository-wide search found no caller, and the method never participated in property lookup, so the practical risk is limited to an unknown external consumer directly calling this unused implementation helper.