[SDAF] Sanity check for files being created by SDAF #21367
Draft
+84
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpalovsky
force-pushed
the
sdaf_path_checks
branch
from
d34114c to
4820885
Compare
lpalovsky
commented
Mar 6, 2025
| @@ -43,6 +43,7 @@ our @EXPORT = qw( | |||
| generate_deployer_name | |||
| get_workload_vnet_code | |||
| get_sdaf_inventory_path | |||
| get_sut_sshkey_path | |||
There was a problem hiding this comment.
SSH key filename was hardcoded in few other places so I added a common function.
lpalovsky
force-pushed
the
sdaf_path_checks
branch
from
4820885 to
fab5c42
Compare
lpalovsky
commented
Mar 6, 2025
| =item * B<sdaf_region_code>: SDAF parameter to choose PC region. Note SDAF is using internal abbreviations (SECE = swedencentral) | ||
|
|
||
| =item * B<vnet_code>: SDAF parameter for virtual network code. Library and deployer use different vnet than SUT env | ||
| =item * B<config_root_path>: SDAF config root path |
There was a problem hiding this comment.
Reducing number of arguments. Full path can be obtained but other function get_sdaf_config_path by the caller.
lpalovsky
force-pushed
the
sdaf_path_checks
branch
3 times, most recently
from
50b8d6e to
e9acbc7
Compare
lilyeyes
reviewed
Mar 7, 2025
| if ($playbook_options->{playbook_filename} eq 'pb_get-sshkey.yaml') { | ||
| record_info('File check', "Check if SSH key '$sut_private_key_path' was created by SDAF"); | ||
| assert_script_run("test -f $sut_private_key_path"); | ||
| } |
There was a problem hiding this comment.
It seems no pb_get-sshkey.yaml related Check if SSH key checking in VR.
There was a problem hiding this comment.
Maybe it should be =~ not eq.
There was a problem hiding this comment.
Oh... thanks. Didn't notice that. Will fix it once I refactor the code.
lpalovsky
force-pushed
the
sdaf_path_checks
branch
2 times, most recently
from
11e9940 to
70207b7
Compare
# Conflicts: # tests/sles4sap/sap_deployment_automation_framework/execute_playbooks.pm
lpalovsky
force-pushed
the
sdaf_path_checks
branch
from
c1d965f to
a3837ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDAF test code is missing sanity checks afte 'sap_systems' deployment wchich
would help troubleshooting SDAF failures. This PR adds checks for important
files that should be created by SDAF - 'SUT ssh key' and 'ansible inventory
file'