Skip to content

Commit

Permalink
Disable IP_CHANGE detection for sles4sap (#21329)
Browse files Browse the repository at this point in the history
IP_CHANGE detection in wait_for_ssh, and in particular when executed in
AWS or GCP, are suing terraform output to detect public IP change.
This technique is not working when used with deployment created by
qe-sap-deployment. Skip this code when used in sles4sap tests.
  • Loading branch information
mpagot authored Mar 4, 2025
1 parent 7e89052 commit 8fa6e58
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/publiccloud/instance.pm
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,8 @@ sub wait_for_ssh {
last if (isok($exit_code) and not $args{wait_stop}); # ssh port open ok
last if (not isok($exit_code) and $args{wait_stop}); # ssh port closed ok

if ($duration >= $args{timeout} - 30) {
# skip SLES4SAP as incompatible with get_public_ip
if (($duration >= $args{timeout} - 30) and (!get_var('PUBLIC_CLOUD_SLES4SAP'))) {
my $public_ip_from_provider = $self->provider->get_public_ip();
if ($args{public_ip} eq $public_ip_from_provider) {
record_info('IP CHANGED', printf("The address we know is %s but provider returns %s", $args{public_ip}, $public_ip_from_provider));
Expand Down

0 comments on commit 8fa6e58

Please sign in to comment.