Enable check for "use strict" and "use warnings"

Perlcritic, as part of our CI, now checks that 'use strict' and 'use
warnings' are present in every module. This commit also includes adding
those lines to all modules that don't have them yet.

Makefile

@@ -90,7 +90,7 @@ else
 test: unit-test test-static test-compile perlcritic
 endif
 
-PERLCRITIC=PERL5LIB=tools/lib/perlcritic:$$PERL5LIB perlcritic --quiet --gentle
+PERLCRITIC=PERL5LIB=tools/lib/perlcritic:$$PERL5LIB perlcritic --quiet --gentle --include "strict"
 
 .PHONY: perlcritic
 perlcritic: tools/lib/

lib/apachetest.pm

@@ -13,6 +13,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use testapi;
 use utils;

lib/apparmortest.pm

@@ -19,6 +19,7 @@
 package apparmortest;
 
 use strict;
+use warnings;
 use testapi;
 use utils;
 use version_utils qw(is_sle is_leap);

lib/bootloader_setup.pm

@@ -13,6 +13,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use File::Basename 'basename';
 use Time::HiRes 'sleep';

lib/btrfs_test.pm

@@ -2,6 +2,7 @@ package btrfs_test;
 use base 'consoletest';
 
 use strict;
+use warnings;
 use testapi;
 use utils 'get_root_console_tty';
 

lib/caasp_controller.pm

@@ -2,6 +2,7 @@ package caasp_controller;
 use base "opensusebasetest";
 
 use strict;
+use warnings;
 use testapi;
 use caasp qw(unpause script_assert0);
 use lockapi qw(barrier_try_wait barrier_destroy);

lib/console_yasttest.pm

@@ -3,6 +3,7 @@
 package console_yasttest;
 use base 'y2logsstep';
 use strict;
+use warnings;
 use testapi;
 use utils 'show_tasks_in_blocked_state';
 

lib/consoletest.pm

@@ -2,6 +2,7 @@ package consoletest;
 use base "opensusebasetest";
 
 use strict;
+use warnings;
 use testapi;
 
 # Base class for all console tests

lib/data_integrity_utils.pm

@@ -15,6 +15,7 @@ package data_integrity_utils;
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi;
 use File::Basename;
 use Digest::file 'digest_file_hex';

lib/hpcbase.pm

@@ -1,6 +1,7 @@
 package hpcbase;
 use base "opensusebasetest";
 use strict;
+use warnings;
 use testapi;
 use utils 'systemctl';
 

lib/installbasetest.pm

@@ -1,6 +1,7 @@
 package installbasetest;
 use base "opensusebasetest";
 use strict;
+use warnings;
 
 # All steps in the installation are 'fatal'.
 

lib/installsummarystep.pm

@@ -2,6 +2,7 @@ package installsummarystep;
 use base "y2logsstep";
 use testapi;
 use strict;
+use warnings;
 
 
 sub accept3rdparty {

lib/kdump_utils.pm

@@ -11,6 +11,7 @@ package kdump_utils;
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi;
 use utils;
 use List::Util 'maxstr';

lib/kernel.pm

@@ -1,6 +1,6 @@
 # SUSE's openQA tests
 #
-# Copyright © 2018 SUSE LLC
+# Copyright © 2018-2019 SUSE LLC
 #
 # Copying and distribution of this file, with or without modification,
 # are permitted in any medium without royalty provided the copyright
@@ -10,6 +10,7 @@ use 5.018;
 use testapi;
 use utils;
 use version_utils 'is_sle';
+use warnings;
 
 our @EXPORT_OK = qw(
   remove_kernel_packages

lib/known_bugs.pm

@@ -16,6 +16,7 @@
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi;
 use main_common;
 use version_utils;

lib/linuxrc.pm

@@ -2,6 +2,7 @@ package linuxrc;
 use base "opensusebasetest";
 use testapi;
 use strict;
+use warnings;
 
 #
 # Shared functionality for handling Linuxrc

lib/mailtest.pm

@@ -11,6 +11,7 @@ package mailtest;
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi;
 use utils;
 use version_utils 'is_tumbleweed';

lib/main_ltp.pm

@@ -24,6 +24,7 @@ use LTP::TestInfo 'testinfo';
 use File::Basename 'basename';
 use main_common qw(load_bootloader_s390x boot_hdd_image get_ltp_tag);
 use 5.018;
+use warnings;
 
 our @EXPORT = 'load_kernel_tests';
 

lib/migration.pm

@@ -19,6 +19,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use testapi;
 use utils;

lib/mm_network.pm

@@ -1,6 +1,7 @@
 package mm_network;
 
 use strict;
+use warnings;
 
 use base 'Exporter';
 use Exporter;

lib/mm_tests.pm

@@ -16,6 +16,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use testapi;
 use utils;

lib/network_utils.pm

@@ -15,6 +15,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 use testapi;
 
 our @EXPORT = qw(setup_static_network recover_network can_upload_logs iface ifc_exists);

lib/networkdbase.pm

@@ -13,6 +13,7 @@
 package networkdbase;
 
 use strict;
+use warnings;
 use testapi;
 use utils;
 

lib/openscaptest.pm

@@ -24,6 +24,7 @@ use Exporter;
 
 use consoletest;
 use strict;
+use warnings;
 use testapi;
 use utils;
 

lib/opensusebasetest.pm

@@ -4,6 +4,7 @@ use base 'basetest';
 use bootloader_setup qw(stop_grub_timeout boot_local_disk tianocore_enter_menu zkvm_add_disk zkvm_add_pty zkvm_add_interface type_hyperv_fb_video_resolution);
 use testapi;
 use strict;
+use warnings;
 use utils;
 use lockapi 'mutex_wait';
 use serial_terminal 'get_login_message';

lib/partition_setup.pm

@@ -12,6 +12,7 @@ package partition_setup;
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi;
 use version_utils ':VERSION';
 use installation_user_settings 'await_password_check';

lib/proxymode.pm

@@ -14,6 +14,7 @@ package proxymode;
 use base 'y2logsstep';
 use testapi;
 use strict;
+use warnings;
 
 our $SLAVE_SERIALDEV = 'proxyserial';
 

lib/publiccloud/basetest.pm

@@ -18,6 +18,7 @@ use publiccloud::azure;
 use publiccloud::ec2;
 use publiccloud::gce;
 use strict;
+use warnings;
 
 sub provider_factory {
     my ($self) = @_;

lib/publiccloud/gce.pm

@@ -18,6 +18,7 @@ use Mojo::Util 'b64_decode';
 use Mojo::JSON 'decode_json';
 use testapi;
 use strict;
+use warnings;
 use utils;
 
 use constant CREDENTIALS_FILE => '/root/google_credentials.json';

lib/qam.pm

@@ -10,6 +10,7 @@
 package qam;
 
 use strict;
+use warnings;
 
 use base "Exporter";
 use Exporter;

lib/registration.pm

@@ -19,6 +19,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use testapi;
 use utils qw(addon_decline_license assert_screen_with_soft_timeout zypper_call systemctl handle_untrusted_gpg_key);

lib/rescuecdstep.pm

@@ -2,6 +2,7 @@ package rescuecdstep;
 use base "opensusebasetest";
 use testapi;
 use strict;
+use warnings;
 
 # Base class for all RESCUECD tests
 

lib/selenium.pm

@@ -12,6 +12,7 @@
 
 package selenium;
 use 5.018;
+use warnings;
 
 use base 'Exporter';
 use Exporter;

lib/sles4sap.pm

@@ -3,6 +3,7 @@ package sles4sap;
 use base "opensusebasetest";
 
 use strict;
+use warnings;
 use testapi;
 use utils;
 use isotovideo;

lib/suseconnect_register.pm

@@ -16,6 +16,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 use testapi;
 use utils;
 use registration;

lib/susedistribution.pm

@@ -2,6 +2,7 @@ package susedistribution;
 use base 'distribution';
 use serial_terminal ();
 use strict;
+use warnings;
 use utils qw(
   disable_serial_getty
   ensure_serialdev_permissions

lib/upload_system_log.pm

@@ -12,6 +12,7 @@ package upload_system_log;
 # Maintainer: Yong Sun <[email protected]>
 
 use strict;
+use warnings;
 use base "Exporter";
 use Exporter;
 use testapi;

lib/utils.pm

@@ -19,6 +19,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 use testapi qw(is_serial_terminal :DEFAULT);
 use lockapi 'mutex_wait';
 use mm_network;

lib/version_utils.pm

@@ -18,6 +18,7 @@ package version_utils;
 use base Exporter;
 use Exporter;
 use strict;
+use warnings;
 use testapi qw(check_var get_var set_var);
 use version 'is_lax';
 

lib/virtmanager.pm

@@ -1,6 +1,7 @@
 package virtmanager;
 use testapi;
 use strict;
+use warnings;
 
 our @ISA    = qw(Exporter);
 our @EXPORT = qw(launch_virtmanager connection_details create_vnet create_new_pool

lib/wickedbase.pm

@@ -20,6 +20,7 @@ use testapi qw(is_serial_terminal :DEFAULT);
 use serial_terminal;
 use Carp;
 use strict;
+use warnings;
 
 =head2 wicked_command
 

lib/windows_utils.pm

@@ -13,6 +13,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 
 use testapi;
 

lib/xen.pm

@@ -14,6 +14,7 @@ package xen;
 
 use base 'consoletest';
 use strict;
+use warnings;
 use testapi;
 use utils;
 

lib/xml_utils.pm

@@ -10,6 +10,7 @@
 # Summary: Library for parsing xml files
 # Maintainer: Rodion Iafarov <[email protected]>
 use strict;
+use warnings;
 use XML::LibXML;
 use Exporter 'import';
 

lib/y2_common.pm

@@ -16,6 +16,7 @@ use base Exporter;
 use Exporter;
 
 use strict;
+use warnings;
 use testapi;
 use version_utils qw(is_opensuse is_leap);
 

lib/y2lan_restart_common.pm

@@ -14,6 +14,7 @@
 package y2lan_restart_common;
 
 use strict;
+use warnings;
 use Exporter 'import';
 use testapi;
 use utils 'systemctl';

lib/y2logsstep.pm

@@ -2,6 +2,7 @@ package y2logsstep;
 use base "installbasetest";
 use testapi;
 use strict;
+use warnings;
 use version_utils qw(is_sle is_caasp);
 use ipmi_backend_utils;
 use network_utils;

lib/y2snapper_common.pm

@@ -1,6 +1,7 @@
 package y2snapper_common;
 
 use strict;
+use warnings;
 use testapi;
 use utils;
 use version_utils;