Skip to content

Conversation

@blackshady
Copy link

@blackshady blackshady commented Aug 2, 2025

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This PR fixes a bug where RecoveryAddress.ID is treated as required, causing the following error when omitted:

uuid: incorrect UUID length 0 in string ""

This breaks identity creation via kratos-client-go and direct API calls when the id field is not set.

The issue is explained here:
🔗 #4454

This fix makes the field optional to allow proper recovery address creation and aligns the behavior with VerifiableAddress, which had a similar bug.

@gaultier
Copy link
Contributor

gaultier commented Aug 4, 2025

Thank you for your contribution!
It looks good to me, can you just run make sdk format to regenerate the SDK and auto-format? Thank you!

@blackshady
Copy link
Author

Done! I’ve run make sdk format and pushed the updated files. Thanks!

@aeneasr
Copy link
Member

aeneasr commented Aug 8, 2025

@gaultier @jonas-jonas you need to approve these PRs in the internal repo, not here!

@icamys
Copy link

icamys commented Oct 27, 2025

Hey folks! What's the status of this PR?
@gaultier @jonas-jonas

@gaultier
Copy link
Contributor

I am working on getting this merged internally.

@gaultier
Copy link
Contributor

gaultier commented Oct 28, 2025

Thank you for your contribution, this has been merged just now: 6f5e79a (I had to do it myself to fix merge conflicts with files OSS contributors do not have access to).

@gaultier gaultier closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants