feat: add inflight rate limiting documentation and improve tooling #2255
+3,095
−1,370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tricky42
commented
Jul 25, 2025
tricky42
commented
- Add comprehensive endpoint-based rate limiting documentation
- Document inflight request limiting for concurrent request protection
- Add protected endpoints table with rate limit types and actions
- Add Makefile help target and dev server target
- Update dependencies to latest minor versions
- Add comprehensive endpoint-based rate limiting documentation - Document inflight request limiting for concurrent request protection - Add protected endpoints table with rate limit types and actions - Add Makefile help target and dev server target - Update dependencies to latest minor versions
tricky42
requested review from
vinckr,
aeneasr,
zepatrik and
piotrmsc
as code owners
|
@vinckr / @Demonsthere review pls |
Demonsthere
reviewed
Sep 5, 2025
| - Provides options for Enterprise and Growth customers to whitelist internal IPs for higher rate limits. | ||
| - Balances security needs with the requirements of high-volume legitimate traffic. | ||
|
|
||
| ### Notes on rate limit rules | ||
| ### Types of endpoint-based protection | ||
|
|
There was a problem hiding this comment.
I think here we should keep the distinction of layers:
- Global CDN layer with Cloudflare
- Local Business logic layer with Envoy
The current proposal flattens that which i don't think is a good idea.
There was a problem hiding this comment.
I intentionally chose not to disclose these "implementation" details, as they shouldn't affect the customer, and it also allows us the flexibility to modify the implementation without needing to update this documentation or notify the customers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.