Render audio graph without emitting to the speakers #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orottier
commented
Nov 3, 2022
| /// The audio output device - use `None` for the default device | ||
| pub sink_id: Option<String>, | ||
|
|
||
| /// The audio output device |
There was a problem hiding this comment.
This API is terrible and I know it. The spec is not much better. I will explore other options
orottier
force-pushed
the
feature/none-sink-id
branch
from
d3d5269 to
2cbab59
Compare
Before: `Option<Option<String>>`
/// - use `None` for the default device
/// - use `Some(None)` to process the audio graph without playing through an audio output device.
/// - use `Some(Some(sinkId))` to use the specified audio sink id, obtained with `enumerate_devices`
After: `Option<String>`
/// - use `None` to process the audio graph without playing through an audio output device.
/// - use `Some("")` for the default audio output device
/// - use `Some(sinkId)` to use the specified audio sink id, obtained with `enumerate_devices`
We now require the user to specify `Some("")` for the default audio
device. In the docs we suggest to use the `::default()` implementation
so you are not required to think about it for most usecases.
|
Hi @b-ma I would love your opinion on my latest API-compliance decision: |
This comment was marked as outdated.
This comment was marked as outdated.
|
Hey! yup I try to check that today or tomorrow |
|
Hey, after reading the spec (which I'm really not sure I understood well) and read again (...a bit fast) WebAudio/web-audio-api#2400, I would personally go for the very simple: This is not very elegant, but much more simple in my opinion... and as the Maybe we should mark the whole thing as unstable until this is implemented in Chrome or Firefox so that we can compare with what they did, to see if we didn't miss something? |
b-ma
reviewed
Nov 8, 2022
src/context/online.rs
Outdated
| @@ -9,6 +11,20 @@ use crate::AudioRenderCapacity; | |||
| use std::error::Error; | |||
| use std::sync::Mutex; | |||
|
|
|||
| /// Check if the provided sink_id is available for playback | |||
| /// | |||
| /// It should be `None` of `Some(sinkId)` where `sinkId` is returned from `enumerate_devices` | |||
There was a problem hiding this comment.
It should be None of or Some(sinkId) ?
No more nested `Option`, just a plain `String`: - use `""` for the default audio output device - use `"none"` to process the audio graph without playing through an audio output device. - use `"sinkId"` to use the specified audio sink id, obtained with [`enumerate_devices`]
|
Thanks for the suggestion. Way simpler indeed. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR for #216
There are some leftover To-dos and your review comments that I will address soon. Thanks for having a look!