Add support for try_reserve under unstable #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested changes
Nov 24, 2018
src/normal.rs
Outdated
| /// # use slotmap::*; | ||
| /// let mut sm = SlotMap::new(); | ||
| /// sm.insert("foo"); | ||
| /// sm.try_reserve(32); |
There was a problem hiding this comment.
Hm. Yes that should have an unwrap. Nice catch.
There was a problem hiding this comment.
Also, I see there is no try_set_capacity?
There was a problem hiding this comment.
@orlp Why do you expect a try_set_capacity? try_reserve is trying to set the capacity...
There was a problem hiding this comment.
It's not reserve because reserve adds capacity, while we want to set the capacity. I don't see the force push though.
There was a problem hiding this comment.
@james-darkfox Ctrl+F try_set_capacity in ce06cbc gives no results.
There was a problem hiding this comment.
Whoops. Wrong one. Fixed. Sorry.
There was a problem hiding this comment.
@orlp bump (github notifications kinda suck...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will need to be tweaked from
std::collections::CollectionAllocErrtocrate::alloc::collections::CollectionAllocErrif #18 is accepted.This is the only conflict between my 4 split PRs.