Modify extension could handle added/deleted items #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an initial implementation, it works in my tests. Also changed how save behaves, it now deletes lazy data only for rows where the save succeeded, so if some server validation fails you do not lose your work in progress. What do you think? |
|
agios, thanks for the pull request. You are right that we plan to implement the lazy add and delete functionality. While we are in the process of releasing gridx 1.3, after the release I will review your code and work with the team on that feature. Thanks again for using and contributing to gridx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There already seems to be some thought for it, assuming that the opt.type=0 parameter in core/model/extensions/Modify.js#set was meant to be used for that purpose.
Is there some reason it was never implemented, or is someone working on it? Otherwise I could maybe take a look at it, although new to Dojo, and JavaScript for that matter.