Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ParsedEnvelope and Envelope public #4249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make ParsedEnvelope and Envelope public #4249

wants to merge 2 commits into from

Conversation

NCrashed
Copy link

Fix #4246, the PR allows people to access ParsedEnvelope::from_transaction for parsing inscriptions from their Rust code.

raphjaph
raphjaph requested changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please run cargo fmt --all to fix the linter error in CI. Normally I would just fix it but I can't push to your master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphjaph raphjaph raphjaph requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ParsedEnvelop::from_transaction public
2 participants
@NCrashed @raphjaph