Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't unnecessarily bump pointer by postage for SameSat mode #4214

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

SmarakNayak
Copy link
Contributor

Noticed that the pointer gets bumped by the postage amount for every inscription even when in SameSat mode. Added a small fix to only bump the pointer when in other modes.

This doesn't change which sat inscriptions are attached to because they all overflow back to a pointer of 0 anyway. You do save some space on unnecessary pointers though.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

This is actually a bug (it can't be triggered because of the way our wallet constructs the transactions). Thanks for the fix, LGTM

@raphjaph raphjaph merged commit 3ca79dc into ordinals:master Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants