Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /r/parents/:inscription_id/inscriptions endpoint. #4088

Merged
merged 17 commits into from
Feb 17, 2025
Merged

Add /r/parents/:inscription_id/inscriptions endpoint. #4088

merged 17 commits into from
Feb 17, 2025

Conversation

gmart7t2
Copy link
Contributor

Analogous to #3771 but for parents instead of children.

@gmart7t2
Copy link
Contributor Author

The examples in the docs for /r/children/.../inscription* have the full output, so I did the same here.

Maybe it makes sense to shorten those examples, too?

casey
casey requested changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The errors in parent_inscriptions_recursive should be handled, see my comment. In general, errors from the index shouldn't be ignored. unwraps on Options are okay though, when we expect the index to contain the inscription.

@cryptoni9n cryptoni9n requested a review from casey February 12, 2025 20:04
@casey
Copy link
Collaborator

casey commented Feb 14, 2025

Can you rebase or merge master? This has some conflicts.

@gmart7t2 gmart7t2 force-pushed the parents-inscriptions-endpoint branch from e4e5ba2 to a14e246 Compare February 14, 2025 21:42
@cryptoni9n cryptoni9n closed this Feb 14, 2025
@cryptoni9n cryptoni9n reopened this Feb 14, 2025
@cryptoni9n
Copy link
Collaborator

Can you rebase or merge master? This has some conflicts.

rebased and ready for review

casey
casey requested changes Feb 16, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me! See comments.

casey
casey approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I removed the include of recursion.md in api.md. It's just too annoying to keep in sync, and it's not a big deal to click a link. @raphjaph Want to take a look and merge, assuming you approve?

raphjaph
raphjaph approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphjaph raphjaph merged commit 176e3fe into ordinals:master Feb 17, 2025
5 checks passed
@cryptoni9n cryptoni9n mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryptoni9n cryptoni9n cryptoni9n left review comments

@casey casey casey approved these changes

@raphjaph raphjaph raphjaph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Tracker
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gmart7t2 @casey @cryptoni9n @raphjaph