Skip to content

Commit

Permalink
Update minimum Bitcoin version to v28 (#4185)
Browse files Browse the repository at this point in the history
  • Loading branch information
raphjaph authored Jan 17, 2025
1 parent 57aa14c commit fe610f6
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion crates/mockcore/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ pub fn builder() -> Builder {
Builder {
fail_lock_unspent: false,
network: Network::Bitcoin,
version: 250000,
version: 280000,
}
}

Expand Down
2 changes: 1 addition & 1 deletion docs/src/guides/wallet.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Installing Bitcoin Core
Bitcoin Core is available from [bitcoincore.org](https://bitcoincore.org/) on
the [download page](https://bitcoincore.org/en/download/).

Making inscriptions requires Bitcoin Core 25 or newer.
Making inscriptions requires Bitcoin Core 28 or newer.

This guide does not cover installing Bitcoin Core in detail. Once Bitcoin Core
is installed, you should be able to run `bitcoind -version` successfully from
Expand Down
2 changes: 1 addition & 1 deletion src/wallet.rs
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ impl Wallet {
}

pub(crate) fn check_version(client: Client) -> Result<Client> {
const MIN_VERSION: usize = 250000;
const MIN_VERSION: usize = 280000;

let bitcoin_version = client.version()?;
if bitcoin_version < MIN_VERSION {
Expand Down
2 changes: 1 addition & 1 deletion tests/wallet/inscribe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ fn inscribe_fails_if_bitcoin_core_is_too_old() {
CommandBuilder::new("wallet inscribe --file hello.txt --fee-rate 1")
.write("hello.txt", "HELLOWORLD")
.expected_exit_code(1)
.expected_stderr("error: Bitcoin Core 25.0.0 or newer required, current version is 24.0.0\n")
.expected_stderr("error: Bitcoin Core 28.0.0 or newer required, current version is 24.0.0\n")
.core(&core)
.ord(&ord)
.run_and_extract_stdout();
Expand Down

0 comments on commit fe610f6

Please sign in to comment.