Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for maxfeerate and maxburnamount to sendrawtransaction #28

Closed
wants to merge 13 commits into from

Conversation

casey
Copy link
Collaborator

@casey casey commented Nov 25, 2024

This needs a test.

@casey
Copy link
Collaborator Author

casey commented Nov 26, 2024

I'm giving up on this. We can't test this PR because the integration tests use an older version of bitcoind which doesn't support maxburnamount. We can't upgrade bitcoind because tests start failing: descriptor wallets are created by default, which breaks commands which rely on descriptor wallets (fixable), and fee rate estimation tests also fail (not sure if we can fix).

This is all too much of a pain in the ass to justify not just trying to work around these issues in ord, instead of trying to do things the "right" way and doing it here.

@casey casey closed this Nov 26, 2024
@casey casey deleted the send-raw-feerate-and-burn branch November 26, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant