Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/aggregate swap #2

Merged
merged 19 commits into from
Mar 15, 2024
Merged

Feat/aggregate swap #2

merged 19 commits into from
Mar 15, 2024

Conversation

meomeocoj
Copy link
Member

  • User need to approve and granting the allowance tokens to the contract to collect fees
  • Swap operations will be infere from packages oraidex-common

@meomeocoj meomeocoj force-pushed the feat/aggregate-swap branch from 2ce9b79 to 6f7e059 Compare March 14, 2024 04:39
trung2891
trung2891 previously approved these changes Mar 14, 2024
tubackkhoa
tubackkhoa previously approved these changes Mar 14, 2024
@meomeocoj meomeocoj dismissed stale reviews from tubackkhoa and trung2891 via 7724abc March 14, 2024 10:12
Copy link

github-actions bot commented Mar 15, 2024

badge

Code Coverage Summary

Filename                                    Stmts    Miss  Cover    Missing
----------------------------------------  -------  ------  -------  ----------------------------------------------------
src/contract.rs                               173      12  93.06%   47-50, 59, 73, 153, 225, 232, 276, 289, 324, 387-388
src/helpers.rs                                  3       1  66.67%   10
src/multitest/contract.rs                      29       0  100.00%
src/multitest/contract_ping_pong_mock.rs       21       2  90.48%   64-65
src/multitest/mock_cw20_contract.rs            38       2  94.74%   87-88
src/multitest/mock_router_contract.rs          44       3  93.18%   98, 125-126
src/multitest/tests.rs                         61       0  100.00%
TOTAL                                         369      20  94.58%

Results for commit: 4ad0964

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

Copy link
Collaborator

@ducphamle2 ducphamle2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@trung2891 trung2891 self-requested a review March 15, 2024 05:38
Copy link
Member

@trung2891 trung2891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meomeocoj meomeocoj merged commit 8bf77c7 into master Mar 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants