Refactor token price retrieval and remove unused denominators in Sele… #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctToken component
haunv3
approved these changes
Mar 3, 2025
quangdz1704
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
AssetsTabandSelectTokencomponents in thesrc/pages/UniversalSwapdirectory. The most important changes focus on improving the handling of token prices and simplifying the token prioritization logic.Improvements to token price handling:
src/pages/UniversalSwap/Component/AssetsTab.tsx: Updated thetokenPriceassignment to use optional chaining fortokenPoolPricesto handle cases wheretokenPoolPricesmight be undefined.Simplification of token prioritization logic:
src/pages/UniversalSwap/Swap/components/SelectToken/SelectToken.tsx: Removed hardcoded token denominations and theprioritizeTokenarray to simplify the token selection component. [1] [2]…ctToken component