Rollback common #302
Rollback common #302
Conversation
WalkthroughThe recent changes streamline the project's GitHub Actions workflow and testing processes. The workflow now triggers on the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant Test Suite
Developer->>GitHub Actions: Push to rollback-common
GitHub Actions->>Test Suite: Run tests
Test Suite->>GitHub Actions: Return test results
GitHub Actions->>Developer: Notify on completion (without Discord)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
Code Coverage SummaryDiff against mainResults for commit: 8888458 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/publish_package_universal_common.yml (2 hunks)
- packages/universal-swap/tests/index.spec.ts (4 hunks)
- tsconfig.build.json (1 hunks)
- tsconfig.json (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/publish_package_universal_common.yml
- tsconfig.build.json
Additional comments not posted (4)
tsconfig.json (1)
5-5: LGTM! But verify module compatibility.The change to
es2020module format aligns with modern JavaScript standards. Ensure that all module loaders and bundlers in the codebase support ES2020 modules.packages/universal-swap/tests/index.spec.ts (3)
118-118: Good addition for time-dependent tests.Using
vi.useFakeTimers()enhances control over time-dependent tests, making them more predictable.
466-466: Revisit and refactor commented out test cases.Several test cases have been commented out. Ensure that these tests are revisited and either refactored or re-enabled to maintain comprehensive test coverage.
Also applies to: 467-467, 468-468, 469-469, 512-539, 542-563, 566-601, 604-634, 639-648, 651-691, 695-719, 721-794, 797-880, 883-974, 976-987, 989-1003, 1005-1019, 1022-1039, 1042-1070, 1073-1085, 1087-1097, 1098-1106, 1109-1293, 1295-1378, 1380-1424, 1426-1760
476-476: Remove console logging in the final version.The
console.logstatement aids in debugging but should be removed or commented out in the final version of the test code.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
Files selected for processing (3)
- package.json (1 hunks)
- packages/oraidex-common/package.json (2 hunks)
- packages/universal-swap/tests/index.spec.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- package.json
Files skipped from review as they are similar to previous changes (1)
- packages/universal-swap/tests/index.spec.ts
Additional comments not posted (2)
packages/oraidex-common/package.json (2)
3-3: Verify the versioning strategy for beta releases.The version has been updated to
1.0.93-beta.2, indicating a beta release. Ensure this aligns with the project's versioning strategy and that all stakeholders are aware of the potential instability.
28-28: Verify compatibility and stability of thetronwebdependency.A new dependency,
tronwebversion6.0.0-beta.4, has been added. Ensure it is compatible with existing dependencies and that the beta version is stable enough for the project's needs.
Summary by CodeRabbit
New Features
Bug Fixes
tronweb, indicating a potential shift in the project's reliance on this library.Tests
Updates
@oraichain/oraidex-commonpackage to a beta release and added a new dependency ontronweb.