feat: bound HTTP resources and client background lifecycle - #74
Open
mahirgupta wants to merge 4 commits into
Open
feat: bound HTTP resources and client background lifecycle#74mahirgupta wants to merge 4 commits into
mahirgupta wants to merge 4 commits into
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA). To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
mahirgupta
force-pushed
the
perf/issue-50-allocation-pooling
branch
from
August 6, 2026 16:10
679258f to
c36f590
Compare
mahirgupta
force-pushed
the
perf/issue-50-resource-lifecycle
branch
from
August 6, 2026 16:10
d4e4d30 to
2b7efda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limit + 1overflowClosecalls safeThis PR is stacked on
perf/issue-50-allocation-poolingso lifecycle and reliability behavior can be reviewed separately from serialization and pooling.Safety
errors.Isanderrors.Aswork for response-size failuresCloseraces are covered, including cancellation of in-flight refresh requestsValidation
go test -modfile=/tmp/nosql-sdk-test.mod -count=1 ./...go test -race -count=1 ./nosqldb ./nosqldb/httputil ./nosqldb/internal/proto/binary ./nosqldb/typesgo vetgo build ./...Five-VM validation used three KVStore servers and two client-side proxies/benchmark clients. The fresh-table workload used one million deterministic 1 KiB rows, 100 workers per client, normal
GOGC=100, and 50/50 Get/Put operations.c3ac733c3ac733Candidate mean throughput was 60,502.50 ops/s versus 51,674.24 for baseline, a 17.08% improvement. Runtime allocations/op fell 4.00%, and GC cycles per million operations fell 13.65%. Candidate p99 latency was also lower in both crossover samples.
Notes
The baseline failures had no SDK call and a one-microsecond recorded latency, identifying them as benchmark measurement-boundary cancellation rather than service errors. Multi-hour endurance and cloud rate-limiter churn remain follow-up validation items.