Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(activemq-client:6.0.0): resolve test failures #599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erguiti-imane
Copy link
Member

What does this PR do?

  • Removed reliance on the legacy javax.jms API and use jakarta.jms instead
  • Regenerate GraalVM metadata for activemq-client 6.0.0

Checklist before merging

- Removed reliance on the legacy javax.jms API and use jakarta.jms instead
- Regenerate GraalVM metadata for activemq-client 6.0.0
@erguiti-imane erguiti-imane requested a review from a team as a code owner February 19, 2025 10:15
@erguiti-imane erguiti-imane requested a review from msupic February 19, 2025 10:15
@dnestoro
Copy link
Member

dnestoro commented Mar 3, 2025

@msupic please review this pull request when possible as we are planning to have a new release of reachability metadata (+Native Build Tools) soon.

@msupic
Copy link
Contributor

msupic commented Mar 4, 2025

After I reformatted the content of new json metadata files from 6.0.0 and compared with json metadata files from 5.18.1, I found that only difference between those files is in one entry from the reflect-config.json file:

  {
    "condition": {
      "typeReachable": "org.apache.activemq.util.LongSequenceGenerator"
    },
    "name": "org.apache.activemq.util.LongSequenceGenerator",
    "fields": [
      {
        "name": "lastSequenceId"
      }
    ]
  }

@erguiti-imane - could you please confirm that? If that is the case, I think that instead of recreating all metadata for 6.0.0, we can have a simple PR which adds above mentioned entry to the reflect-config.json file 5.18.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants