-
Notifications
You must be signed in to change notification settings - Fork 96
fix(activemq-client:6.0.0): resolve test failures #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(activemq-client:6.0.0): resolve test failures #599
Conversation
- Removed reliance on the legacy javax.jms API and use jakarta.jms instead - Regenerate GraalVM metadata for activemq-client 6.0.0
@msupic please review this pull request when possible as we are planning to have a new release of reachability metadata (+Native Build Tools) soon. |
After I reformatted the content of new json metadata files from
@erguiti-imane - could you please confirm that? If that is the case, I think that instead of recreating all metadata for |
I had to make some changes to the tests by removing the reliance on the legacy javax.jms API and replacing it with jakarta.jms, which is why I generated new metadata. As we previously agreed, whenever a library starts breaking, we create a new directory and use it for all subsequent versions until another breaking change occurs. This approach helps keep things organized. What do you think, @dnestoro ? |
5a787d3
to
8fd4270
Compare
@erguiti-imane if you changed tests compared to the previous supported version, add another entry (directory for tests and metadata) as we agreed. Only when we have same tests (and you just regenerates metadata), you may just update metadata |
I made the changes to the test class specifically for version 6.0.0, where jakarta.jms is expected. However, for older versions like 5.18.1, ActiveMQ is still based on javax.jms (Java EE 8 / legacy APIs). I tested to confirm, and the changes broke tests for older version. |
@msupic can you please review this pull request and add comments if something needs to be changed? If there is no issues remain, we should proceed with merging this PR. |
What does this PR do?
Checklist before merging