Skip to content

Extend wrapped JS function coverage in core runtime types #12263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 28, 2025
Merged

Extend wrapped JS function coverage in core runtime types #12263

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7bf670a
add functions to JSObject, JSNumber, JSString, JSSymbol, JSValue; ren…
Atur256 Sep 30, 2025
16caca3
add tests for JSNumber, JSObject, JSString, JSSymbol
Atur256 Oct 3, 2025
be7ba5e
implement pr comments
Atur256 Oct 8, 2025
69c5127
implement pr comments
Atur256 Oct 14, 2025
13ac2f3
implement pr comments
Atur256 Oct 14, 2025
cbcdb84
implement pr comments
Atur256 Oct 27, 2025
3c49212
implement pr comments
Atur256 Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSObject.java
View file
Open in desktop
Copy link
Member

@patrick96 patrick96 Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the assign, getOwnPropertySymbols, getPrototypeOf, and getOwnPropertyDescriptors methods

Copy link
Contributor Author

@Atur256 Atur256 Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were all functions that I was not able to implement for various reasons and therefore left out.

Copy link
Member

@patrick96 patrick96 Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine in that case. We can add them once we fix the underlying issues

Original file line number Diff line number Diff line change
Expand Up @@ -537,9 +537,12 @@ public double[] asDoubleArray() {
@SuppressWarnings("unchecked")
@Override
public <T> T as(Class<T> cls) {
Object facade = extractFacadeClass(cls);
if (cls.isAssignableFrom(this.getClass())) {
return (T) this;
}
T facade = extractFacadeClass(cls);
if (facade != null) {
return (T) facade;
return facade;
}
return super.as(cls);
}
Expand Down
2 changes: 1 addition & 1 deletion sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSSymbol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public int hashCode() {

public static String keyFor(JSSymbol sym) {
JSValue result = keyForRaw(sym);
return result instanceof JSUndefined ? null : result.asString();
return JSValue.isUndefined(result) ? null : result.asString();
}

@JS.Coerce
Expand Down
10 changes: 10 additions & 0 deletions sdk/src/org.graalvm.webimage.api/src/org/graalvm/webimage/api/JSValue.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,16 @@ public static <R> R checkedCoerce(Object value, Class<R> cls) {
return (R) value;
}

/**
* Checks whether the given JSValue is the JavaScript 'undefined' value.
*
* @param value the JSValue to check
* @return true if the value is an instance of JSUndefined, false otherwise
*/
public static boolean isUndefined(JSValue value) {
return value instanceof JSUndefined;
}

public static JSUndefined undefined() {
return JSUndefined.instance();
}
Expand Down