feat:Block volume with autotune config by vladcristi · Pull Request #501 · oracle/cluster-api-provider-oci

vladcristi · 2026-02-20T12:36:47Z

What this PR does:

adds the possibility to specify block volume configuration with autotune enabled for cluster nodes.
Fixes also an issue regarding bringing up cluster nodes with block volume attachments using launchVolumeAttachments with volumeId instead of launchParavirtualizedVolumeAttachment/launchIscsiVolumeAttachment block to be able to use previously created block volumes outside CAPOCI
add the possibility to specify both block volume attachments to a cluster node with both autotune enabled configuration using blockVolumeSpec or using launchVolumeAttachments at the same time

Why we need it:
At instance creation you cannot specify autotune enabled configuration for your attached block volume: https://github.com/oracle/oci-go-sdk/blob/master/core/launch_instance_details.go -> https://github.com/oracle/oci-go-sdk/blob/master/core/launch_create_volume_from_attributes.go
In order to do that you should create a block volume with that configuration and after that at instance creation specify that block volume for attachments.

The changes from this PR give the capability to run that logic behind the scenes just by specifying in OCIMachineTemplate the blockvolumeSpec block with its fields. There is an example under templates/cluster-template-with-bv-autotuned.yaml

Which issue(s) this PR fixes :
Fixes #462

Checklist

All unit tests are passing
All PRBlocking tests are passing
Code builds successfully

…onfiguration

…une_config

vladcristi · 2026-02-20T12:39:35Z

Unit tests output:

        github.com/oracle/cluster-api-provider-oci              coverage: 0.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta1  19.231s coverage: 23.7% of statements
ok      github.com/oracle/cluster-api-provider-oci/api/v1beta2  0.051s  coverage: 17.3% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/config 0.009s  coverage: 86.1% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/hash   0.015s  coverage: 97.8% of statements
       github.com/oracle/cluster-api-provider-oci/cloud/metrics                coverage: 0.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil        0.008s  coverage: 23.2% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/ociutil/ptr    0.029s  coverage: 100.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/scope  22.389s coverage: 74.4% of statements
       github.com/oracle/cluster-api-provider-oci/cloud/scope/mocks            coverage: 0.0% of statements
       github.com/oracle/cluster-api-provider-oci/cloud/services/base          coverage: 0.0% of statements
       github.com/oracle/cluster-api-provider-oci/cloud/services/base/mock_base                coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/compute       [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/compute/mock_compute          coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement     [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/computemanagement/mock_computemanagement              coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine       [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/containerengine/mock_containerengine          coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/identity      [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/identity/mock_identity                coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer  [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/loadbalancer/mock_lb          coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer   [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/networkloadbalancer/mock_nlb          coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn   [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/vcn/mock_vcn          coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/volume        [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/volume/mock_volume            coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests  [no test files]
       github.com/oracle/cluster-api-provider-oci/cloud/services/workrequests/mock_workrequests                coverage: 0.0% of statements
ok      github.com/oracle/cluster-api-provider-oci/cloud/util   0.152s  coverage: 60.4% of statements
ok      github.com/oracle/cluster-api-provider-oci/controllers  7.136s  coverage: 59.7% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta1      5.487s  coverage: 15.3% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/api/v1beta2      0.025s  coverage: 5.8% of statements
ok      github.com/oracle/cluster-api-provider-oci/exp/controllers      0.713s  coverage: 56.0% of statements
       github.com/oracle/cluster-api-provider-oci/feature              coverage: 0.0% of statements
?       github.com/oracle/cluster-api-provider-oci/version      [no test files]
grep -v 'zz_generated' coverage.out > coverage_filtered.out
go tool cover -func=coverage_filtered.out -o coverage.txt
go tool cover -html=coverage_filtered.out -o coverage.html

E2e tests output:

Ran 9 of 31 Specs in 3921.596 seconds
SUCCESS! -- 9 Passed | 0 Failed | 0 Pending | 22 Skipped

joekr · 2026-02-20T16:40:12Z

api/v1beta1/types.go

+	//   * `20`: Represents Higher Performance option.
+	//   * `30`-`120`: Represents the Ultra High Performance option.
+	// For performance autotune enabled volumes, it would be the Default(Minimum) VPUs/GB.
+	VpusPerGB *int64 `json:"vpusPerGB,omitempty"`


I'm sure I'll find out later in the code, but do we validate these values?

joekr · 2026-02-20T16:42:41Z

api/v1beta1/types.go

 	RPCConnectionId *string `json:"rpcConnectionId,omitempty"`
 }

+type BlockVolumeSpec struct {


I know we aren't perfect with this, but should we add // +optional for any param that is optional?
or call out defaults we set on behalf of the user

joekr · 2026-02-20T16:45:01Z

api/v1beta1/types.go

+
+	// The type of volume attachment used to attach this block volume to the instance
+	VolumeType string `json:"volumeType,omitempty"`
+}


There are a lot of new values here that can be set. Have we tested them all? should we make a new e2e test?

joekr · 2026-02-20T16:47:08Z

api/v1beta1/types.go

+
+	// The availability domain of the block volume replica.
+	// Example: `Uocm:PHX-AD-1`
+	AvailabilityDomain *string `json:"availabilityDomain,omitempty"`


I don't know enough about this. I see there is a cross region and cross AD replication support. Does this support both of those? Have we tested this works? Is there a way we can e2e test this works? or something?

joekr · 2026-02-20T16:47:27Z

api/v1beta1/types.go

+
+type AutotunePolicy struct {
+	// This field can be of type DETACHED_VOLUME or PERFORMANCE_BASED
+	AutotuneType string `json:"autotuneType,omitempty"`


I'm sure I'll find out later in the code, but do we validate these values?

joekr · 2026-02-20T19:37:24Z

cloud/scope/machine.go

+				},
+			}...)
+		} else {
+			m.Logger.Info("Unknown attachment type not supported")


should we log this as error?

joekr · 2026-02-20T19:38:42Z

cloud/scope/machine.go

+		}
+
+		m.Logger.Info("Instance state, waiting...", "state", getInstanceResp.Instance.LifecycleState)
+		time.Sleep(5 * time.Second)


we probably also want to need some exit here as well. I'm not sure what that might be though 🤔

joekr · 2026-02-20T19:39:23Z

cloud/scope/machine.go

+		getInstanceResp, err := m.ComputeClient.GetInstance(ctx, getInstanceReq)
+		if err != nil {
+			if serviceErr, ok := err.(common.ServiceError); ok {
+				if serviceErr.GetHTTPStatusCode() == 404 {


lets use ociutil.IsNotFound here

joekr · 2026-02-20T19:40:04Z

cloud/scope/machine.go

+					break
+				}
+			}
+			m.Logger.Info("Error checking instance state", "error", err.Error())


lets log this as an error

Also if there is an error here we will still try to delete the DeleteBlockVolume below? Will that work?

joekr · 2026-02-20T19:44:46Z

cloud/scope/machine.go

 	if instance != nil {
 		m.Logger.Info("Found an existing instance")
+		m.Logger.Info("Reconcile block volume")
+		m.ReconcileBlockVolume(ctx)


Doesn't this return an error?

~~Also what will happen here if the instance already exists, will a new blockvolume be created? will that leak resources?~~

it looks like ReconcileBlockVolume gets the BV by name, if found it doesn't do anything what happens if the user wants to update the display name? Do we handle that case? Reading the code it seems it might create a new BV.

vladcristi added 7 commits February 3, 2026 08:48

added block volume creation

bf36907

added all components for block volume create/update/delete

3b7c417

moved block volume creation from cluster to machine

4ffdc8a

removed minor unneeded changes

56e3161

added create/delete cluster node with block volume autotune enabled c…

241c565

…onfiguration

final refinements after unit tests and e2e tests

0f0b923

Merge branch 'add_block_volume_creation' into block_volume_with_autot…

e8f0b92

…une_config

oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 20, 2026

vladcristi requested a review from joekr February 20, 2026 12:42

joekr reviewed Feb 20, 2026

View reviewed changes

vladcristi and others added 3 commits February 24, 2026 15:36

changes according to PR comments - first part

53980fc

Merge branch 'oracle:main' into block_volume_with_autotune_config

76dd8e7

Merge branch 'oracle:main' into block_volume_with_autotune_config

e775256

Conversation

vladcristi commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

vladcristi commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit tests output:

E2e tests output:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vladcristi commented Feb 20, 2026 •

edited

Loading

vladcristi commented Feb 20, 2026 •

edited

Loading