[AQUA] Add API endpoints to manage chat templates via model custom metadata #1213
+149
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added post endpoint for Model Tokenizer - Updated chat template API endpoint in AquaModelChatTemplateHandler - Added test cases for AquaModelChatTemplateHandler
siddhantm005
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
mrDzurb
approved these changes
Jul 3, 2025
| @@ -381,7 +423,7 @@ def post(self, model_id: str, metadata_key: str): | |||
| ("model/?([^/]*)", AquaModelHandler), | |||
| ("model/?([^/]*)/license", AquaModelLicenseHandler), | |||
| ("model/?([^/]*)/readme", AquaModelReadmeHandler), | |||
| ("model/?([^/]*)/tokenizer", AquaModelTokenizerConfigHandler), | |||
| ("model/?([^/]*)/chat-template", AquaModelChatTemplateHandler), | |||
There was a problem hiding this comment.
On UI side we also will have this change?
There was a problem hiding this comment.
Yes, we will update the UI with the new endpoint.
|
📌 Cov diff with main: 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new API handler, AquaModelChatTemplateHandler, replacing the previous AquaModelTokenizerConfigHandler functionality related to chat templates.
Changes
Retrieves the chat template from a model’s custom metadata instead of the Hugging Face tokenizer configuration.
Endpoint:
GET /aqua/model/<model-ocid>/chat-templateAllows adding or updating a custom chat template metadata artifact for a given model.
Endpoint:
POST /aqua/model/<model-ocid>/chat-templatePayload:
{ "chat_template": "<chat_template_string>" }Unit Tests