Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ios security alarms #1592

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Ios security alarms #1592

wants to merge 16 commits into from

Conversation

bios62
Copy link
Collaborator

@bios62 bios62 commented Feb 17, 2025

Added new asset to the CISO team publication, OCI Observability alarms to security monitoring
Enhancement on the Security Fundamentals Dashboard, alarm generation.

@bios62 bios62 requested a review from pdtoal February 17, 2025 10:03
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 17, 2025
@pdtoal pdtoal requested review from oheimburger and pdtoal and removed request for pdtoal February 17, 2025 10:13
pdtoal
pdtoal requested changes Feb 21, 2025
View reviewed changes
Copy link
Member

@pdtoal pdtoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a bunch of changes to the source and checked-in the update. Have a look and see what you think. In addition, the comments below are a few bits that need clarification

bios62
bios62 commented Feb 22, 2025
View reviewed changes
Copy link
Collaborator Author

@bios62 bios62 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for great input. Changes are added to my last commit.
The pictures are updated with marks on where to edit.
Some other cosmetic changes as well done

@bios62
Update README.md after review
4812de1 
Applied most of your changes as requested
@bios62
adjusted network_dashboard.png
70d83ac
@bios62
adjusted network_dashboard.png network_dashboard_2.png
ae47e61
@bios62
Update README.md, corrected UI Menus
03229eb 
Consistent usage of UI Menu
@bios62
Update README.md
0901d87 
Corrected one additional OCI UI menu reference to be consistent with the actual menu in the UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdtoal pdtoal pdtoal requested changes

@oheimburger oheimburger oheimburger requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bios62 @pdtoal @oheimburger