One-Click LP: Collect Fees #598
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
deepthinker250
approved these changes
Jul 14, 2022
aleone
approved these changes
Aug 2, 2022
| @@ -17,6 +17,7 @@ import { useGetDebtAmount, useGetTwapSqueethPrice, useGetVault } from '../contro | |||
| const TICK_SPACE = 60 | |||
| const COLLAT_RATIO = 1.5 | |||
| const POOL_FEE = 3000 | |||
| const MAX_INT = new BigNumber(2).pow(128).minus(1).toFixed(0) | |||
There was a problem hiding this comment.
maybe call this MAX_INT_128 or something, might need MAX_INT_256 later, etc
|
|
||
| const shortAmount = fromTokenAmount(vaultBefore.shortAmount, OSQUEETH_DECIMALS) | ||
| const debtInEth = await getDebtAmount(shortAmount) | ||
| const collateralToFlashloan = debtInEth.multipliedBy(COLLAT_RATIO) |
There was a problem hiding this comment.
for all of these we need to have some buffer room.
If the transaction takes some time to be mined and spot prices change, its possible we won't be borrowing enough ETH.
Maybe 200% is fine?
added 17 commits
August 8, 2022 23:00
daryakaviani
force-pushed
the
one-click-lp-close
branch
from
1dce1e0 to
151b0fb
Compare
daryakaviani
force-pushed
the
one-click-lp-fees
branch
from
d73e710 to
b9e7ad0
Compare
daryakaviani
force-pushed
the
one-click-lp-close
branch
from
047d506 to
77b8d9c
Compare
|
|
||
| export const CONTROLLER_HELPER: Address = { | ||
| 1: '0xfa86d43b41Fa7a759c606130cc81970A955ff816', | ||
| 3: '0x7e9C5490e91F93529c6480B46a59D738F6bcEa43', |
There was a problem hiding this comment.
should add goerli deployment
aleone
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: One-Click LP Collect Fees
Description
Collect fees accumulated by an LP position via the ControllerHelper's
rebalanceLpInVaultfunction.Learn more about the One-Click LP API here.