Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update auction length #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update auction length #438

wants to merge 1 commit into from

Conversation

haythemsellami
Copy link
Member

@haythemsellami haythemsellami commented Jun 29, 2021 •
edited
Loading

Update auction length

Code

  • Unit test 100% coverage
  • Does your code follow the naming and code documentation guidelines?

Documentation

  • Is your code up to date with the spec?
  • Have you added your tests to the testing doc?

@haythemsellami haythemsellami added the gamma-v2.0.0 Opyn partial collateralization label Jun 29, 2021
CruzMolina
CruzMolina previously approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why a couple of the unit tests are failing.

aparnakr
aparnakr previously approved these changes Feb 4, 2022
View reviewed changes
@CruzMolina
Copy link
Contributor

:shipit:

@haythemsellami haythemsellami dismissed stale reviews from aparnakr and CruzMolina via d22e8a4 September 9, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aparnakr aparnakr aparnakr left review comments

@CruzMolina CruzMolina CruzMolina left review comments

@antoncoding antoncoding Awaiting requested review from antoncoding

@aleone aleone Awaiting requested review from aleone

@alexisgauba alexisgauba Awaiting requested review from alexisgauba

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
gamma-v2.0.0 Opyn partial collateralization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haythemsellami @CruzMolina @aparnakr