Refactor XeSS #482
Closed
Refactor XeSS #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PotatoOfDoom
force-pushed
the
refactorXess
branch
from
5e4b028 to
bbe43b7
Compare
mporsch
reviewed
Jun 20, 2025
| XeSSFeatureDx12::~XeSSFeatureDx12() {} | ||
| XeSSFeatureDx12::~XeSSFeatureDx12() | ||
| { | ||
| if (_localPipeline != nullptr) |
There was a problem hiding this comment.
use unique_ptr with a custom deleter like https://github.com/mporsch/sockpuppet/blob/master/src/socket_tls_impl.h#L24-L28
-edit: nevermind; this approach can get its own PR #543
mporsch
reviewed
Jun 20, 2025
| State::Instance().skipHeapCapture = true; | ||
|
|
||
| ID3D12Device1* device1; | ||
| if (FAILED(device->QueryInterface(IID_PPV_ARGS(&device1)))) |
There was a problem hiding this comment.
this is the use case for out_ptr which should be available in VS2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to start somewhere...