Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update e2e workflow names #11223

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Conversation

kevintab95
Copy link
Member

@kevintab95 kevintab95 commented Nov 20, 2020

Overview

  1. This PR fixes or fixes part of #[fill_in_number_here].
  2. This PR does the following: Update e2e workflow names and adds a README file.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The linter/Karma presubmit checks have passed locally on your machine.
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
    • This lets reviewers restart your CircleCI tests for you.
  • The PR is made from a branch that's not called "develop".

PR Pointers

  • Make sure to follow the instructions for making a code change.
  • Oppiabot will notify you when you don't add a PR_CHANGELOG label. If you are unable to do so, please @-mention a code owner (who will be in the Reviewers list), or ask on Gitter.
  • For what code owners will expect, see the Code Owner's wiki page.
  • Make sure your PR follows conventions in the style guide, otherwise this will lead to review delays.
  • Never force push. If you do, your PR will be closed.

@oppiabot
Copy link

oppiabot bot commented Nov 20, 2020

Hi, @kevintab95, this pull request does not have a "CHANGELOG: ..." label as mentioned in the PR checkbox list. Assigning @ kevintab95 to add the required label. PRs without this label will not be merged. If you are unsure of which label to add, please ask the reviewers for guidance. Thanks!

@oppiabot
Copy link

oppiabot bot commented Nov 20, 2020

Hi @kevintab95, the karma and linter checklist has not been checked, please make sure to run the frontend tests and lint tests before pushing. Thanks!

@seanlip
Copy link
Member

seanlip commented Nov 20, 2020

LGTM, merging per discussion with @kevintab95 so that folks don't have to merge from develop multiple times.

@oppiabot oppiabot bot unassigned seanlip Nov 20, 2020
@oppiabot
Copy link

oppiabot bot commented Nov 20, 2020

Unassigning @seanlip since they have already approved the PR.

@oppiabot
Copy link

oppiabot bot commented Nov 20, 2020

Assigning @vinitamurthi for code owner reviews. Thanks!

@seanlip seanlip merged commit bb16fbe into oppia:develop Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants