Fix #357: Add "Solve your first starter issue" page -> https://github.com/oppia/oppia-web-developer-docs/issues/357 #458
Conversation
Add "make sure reviewers are assigned" Add more links fromm existing PR guide in point 8 and 9
In the Siderbar, add "Solve your first starter issue" under "Making your first PR"
There was a problem hiding this comment.
@LittleRainC I think this looks good! But before we merge it, could you please follow step 1 here? https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up Thanks.
|
@seanlip So, I'm a individual developer and I think I've already signed the individual CLA before because the page shows this: |
|
Oh, I see what happened, you misspelled your GitHub username (LittlaRainC). I'll fix it -- thanks for checking! |
_Sidebar.md
Outdated
| * [[How the codebase is organized|Overview-of-the-Oppia-codebase]] | ||
| * Making your first PR | ||
| * **[[Good first issues|https://github.com/oppia/oppia/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22]]** | ||
| * [[Solve your first starter issue|Solve your first starter issue]] |
There was a problem hiding this comment.
I just realized, are you sure this link works correctly? Notice the pattern used in the other links for the second part.
There was a problem hiding this comment.
Fix the link for "Solve your first started issue" in the Sidebar file
Solve your first starter issue.md
Outdated
| After you open a pull request, make sure the reviewer are assigned to the PR (make sure they appear in "Assignees"). Reviewers will leave comments or suggestions. Review carefully and take action accordingly: | ||
|
|
||
| - Make the requested changes to your code | ||
| - Reply to each comment to confirm what you've done or to ask for clarification, following [address review comments](https://github.com/oppia/oppia/wiki/Rules-for-making-PRs#step-5-address-review-comments-until-all-reviewers-approve) |
There was a problem hiding this comment.
This doesn't look right -- see the preview, it reads as "following address review comments" which is not grammatical. If you are referring to a section in a wiki page, please match the section header exactly (including upper/lower case) and put quotes around the text you're quoting from another page.
There was a problem hiding this comment.
Adjusted. What do you think about this? I didn't find any reference so, I just added "in our PR guide".
Solve your first starter issue.md
Outdated
|
|
||
| Once all reviewer comments are resolved: | ||
|
|
||
| - Make sure all required checks (CI, lint, tests) are passing, following [make all checks pass](https://github.com/oppia/oppia/wiki/Rules-for-making-PRs#step-6-make-sure-all-continuous-integration-checks-pass) |
Fix the link for "Solve your first starter issue" in Sidebar
Improved the grammar for links
There was a problem hiding this comment.
Sorry for the late reply @LittleRainC. This all LGTM -- thanks!
2 participants
Changed fffiles:
You can review it through -> Solve your first starter issue