Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4132: Added tests for MathParsingErrorSubject. #5684
base: develop
Are you sure you want to change the base?
Fixes #4132: Added tests for MathParsingErrorSubject. #5684
Changes from 7 commits
a0da327
8506a9d
1adfca1
732ecfa
8b7b29e
924fb0b
fba1534
5dcf660
146c897
2a6f5a5
ae83986
4b66540
eef800e
dc12843
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the test below can be better structure following the example usage set in
oppia-android/utility/src/test/java/org/oppia/android/util/math/MathExpressionParserTest.kt
Line 201 in 38419bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and all tests below: It is not clear why you are creating the
subject
variable since it is not being used. Assertions are independent expressions and should not be assigned to a variable.