Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #3000 : TODO Integrate Buildifier Linter into Pre-push Checks #5674

Merged
merged 11 commits into from
Feb 19, 2025
Merged

Fix part of #3000 : TODO Integrate Buildifier Linter into Pre-push Checks #5674

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bafceb4
Add Buildifier linter
TanishMoral11 Jan 27, 2025
be394fb
Reformatting
TanishMoral11 Jan 27, 2025
c447faa
Update
TanishMoral11 Jan 27, 2025
e418e49
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Jan 28, 2025
e8b9f32
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Jan 31, 2025
3189b4a
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Feb 10, 2025
cb1dd48
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Feb 12, 2025
20a83bc
Merge branch 'develop' into feature/bazel-linter-integration
adhiamboperes Feb 13, 2025
8012bc5
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Feb 13, 2025
c3eb03b
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Feb 13, 2025
434204d
Merge branch 'develop' into feature/bazel-linter-integration
TanishMoral11 Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/pre-push.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,14 @@ source scripts/formatting.sh
# - ktlint
# - checkstyle
# - buf
# - buildifier
# - (others in the future)

if bash scripts/ktlint_lint_check.sh && bash scripts/checkstyle_lint_check.sh && bash scripts/buf_lint_check.sh ; then
if bash scripts/ktlint_lint_check.sh && bash scripts/checkstyle_lint_check.sh && bash scripts/buf_lint_check.sh && bash scripts/buildifier_lint_check.sh; then
echo_success "All checks passed successfully"
exit 0
else
exit 1
fi

# TODO(#3000): Add Bazel Linter to the project
# TODO(#970): Add XML Linter to the project
Loading