Skip to content

acme: small depreciation fix #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sopex wants to merge 6 commits into
base: master
Choose a base branch
from
Open

acme: small depreciation fix #4938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2236724
Update LeCertificate.php
sopex Sep 9, 2025
ec95af4
Update SettingsController.php
sopex Sep 14, 2025
cf378d2
Update SettingsController.php
sopex Sep 14, 2025
ae9e075
Merge branch 'acme' of https://github.com/sopex/plugins into acme
sopex Sep 14, 2025
93a4857
changelog
sopex Nov 19, 2025
9a1729a
Merge branch 'master' into acme
sopex Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions security/acme-client/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
PLUGIN_NAME= acme-client
PLUGIN_VERSION= 4.10
PLUGIN_REVISION= 2
PLUGIN_VERSION= 4.10.1
PLUGIN_COMMENT= ACME Client
PLUGIN_MAINTAINER= [email protected]
PLUGIN_DEPENDS= acme.sh py${PLUGIN_PYTHON}-dns-lexicon
Expand Down
5 changes: 5 additions & 0 deletions security/acme-client/pkg-descr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@ WWW: https://github.com/acmesh-official/acme.sh
Plugin Changelog
================

4.10.1

Fixed:
* syntax depreciation caused errors (#4938)

4.10

Added:
Expand Down
4 changes: 2 additions & 2 deletions ...me-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public function fetchCronIntegrationAction()
} else {
// Cron job NOT found. This should not happen, try to fix
// this automatically.
$this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: ${cron_uuid}");
$this->getLogger()->error("AcmeClient: cron job with stored UUID not found in system config: {$cron_uuid}");

// Search for existing AcmeClient cron job.
foreach ((new Cron())->getNodeByReference('jobs.job')->iterateItems() as $cron) {
Expand All @@ -86,7 +86,7 @@ public function fetchCronIntegrationAction()
if ($_origin == 'AcmeClient') {
// Found a matching AcmeClient cron job.
$cron_found = 1;
$this->getLogger()->notice("AcmeClient: found existing AcmeClient cron job, fixing inconsistency in config (new UUID: ${_uuid})");
$this->getLogger()->notice("AcmeClient: found existing AcmeClient cron job, fixing inconsistency in config (new UUID: {$_uuid})");
// Update UUID in Acme Client config.
$mdlAcme->settings->UpdateCron = $_uuid;
// Save updated configuration.
Expand Down
5 changes: 5 additions & 0 deletions security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ class LeCertificate extends LeCommon
{
public const CONFIG_PATH = 'certificates.certificate';

protected $cert_file;
protected $cert_key_file;
protected $cert_chain_file;
protected $cert_fullchain_file;

/*
* Create the object by collecting and storing all required data
* @param $uuid string the UUID of the configuration object
Expand Down