Skip to content

added optional OTP field to login form (issue #8239) #9179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jullrich wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Open

added optional OTP field to login form (issue #8239) #9179

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9e97b8
added optional OTP field to login form
jullrich Sep 4, 2025
631c07e
added optional OTP field to login form
jullrich Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/www/authgui.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,12 @@ function session_auth()

/* Validate incoming login request */
if (isset($_POST['login']) && !empty($_POST['usernamefld']) && !empty($_POST['passwordfld'])) {
$tmp_otp = '';
if (!empty($_POST['otpfld']) && is_numeric($_POST['otpfld'])) {
$tmp_otp = $_POST['otpfld'];
}
$authFactory = new \OPNsense\Auth\AuthenticationFactory();
$is_authenticated = $authFactory->authenticate("WebGui", $_POST['usernamefld'], $_POST['passwordfld']);
$is_authenticated = $authFactory->authenticate("WebGui", $_POST['usernamefld'], $_POST['passwordfld'].$tmp_otp);

if ($is_authenticated) {
$authenticator = $authFactory->lastUsedAuth;
Expand All @@ -178,7 +182,7 @@ function session_auth()
$_SESSION['Username'] = $authenticator->getUserName($_POST['usernamefld']);
$_SESSION['last_access'] = time();
$_SESSION['protocol'] = $config['system']['webgui']['protocol'];
if ($authenticator != null && $authenticator->shouldChangePassword($_SESSION['Username'], $_POST['passwordfld'])) {
if ($authenticator != null && $authenticator->shouldChangePassword($_SESSION['Username'], $_POST['passwordfld'].$tmp_otp)) {
$_SESSION['user_shouldChangePassword'] = true;
}
if (!isset($config['system']['webgui']['quietlogin'])) {
Expand Down Expand Up @@ -410,7 +414,10 @@ function display_login_form($Login_Error)
<label for="passwordfld"><?=gettext("Password:"); ?></label>
<input id="passwordfld" type="password" name="passwordfld" class="form-control pwd" tabindex="2" />
</div>

<div class="form-group">
<label for="otpfld"><?=gettext("Optional OTP:"); ?></label>
<input id="otpfld" type="tel" name="otpfld" class="form-control pwd" tabindex="3" />
</div>
<button type="submit" name="login" value="1" class="btn btn-primary pull-right"><?=gettext("Login"); ?></button>

</form>
Expand Down