Correct the floating logic in the FilterRuleField.php

Author: Monviech

src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php

@@ -178,7 +178,6 @@ public function searchRuleAction()
             $is_cat = empty($categories) || array_intersect(explode(',', $record->categories), $categories);
             $rule_interfaces = array_filter(explode(',', (string)$record->interface));
 
-            /* inverted interface acts as floating rule */
             if ((string)$record->interfacenot === "1") {
                 $rule_interfaces = [];
             }
@@ -227,7 +226,6 @@ public function searchRuleAction()
             if (empty($interfaces)) {
                 $is_if = empty($record['interface']) || count(explode(',', $record['interface'])) > 1;
             } elseif ((string)$record['interfacenot'] === "1") {
-                /* inverted interface acts as floating rule */
                 $is_if = true;
             } else {
                 $is_if = array_intersect(explode(',', $record['interface'] ?? ''), $interfaces);

src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php

@@ -109,11 +109,12 @@ public function getPriority()
         $configObj = Config::getInstance()->object();
         $interface = (string)$this->interface;
 
-        if ((string)$this->interfacenot === "1" && !empty($interface)) {
-            // floating (inverted interface)
-            return 200000;
-        } elseif (strpos($interface, ",") !== false || empty($interface)) {
-            // floating (multiple interfaces involved)
+        if (
+            // floating (multiple interfaces or inverted interface)
+            (string)$this->interfacenot === "1" ||
+            (strpos($interface, ",") !== false && !empty($interface)) ||
+            empty($interface)
+        ) {
             return 200000;
         } elseif (
             !empty($configObj->interfaces) &&