Firewall: Rules [new]: Fix handling of interfacenot, evaluate as floating rules in correct prio_group

Author: Monviech

src/opnsense/mvc/app/controllers/OPNsense/Firewall/Api/FilterController.php

@@ -178,6 +178,11 @@ public function searchRuleAction()
             $is_cat = empty($categories) || array_intersect(explode(',', $record->categories), $categories);
             $rule_interfaces = array_filter(explode(',', (string)$record->interface));
 
+            /* inverted interface acts as floating rule */
+            if ((string)$record->interfacenot === "1") {
+                $rule_interfaces = [];
+            }
+
             if (empty($interfaces)) {
                 $is_if = count($rule_interfaces) != 1;
             } elseif ($show_all) {
@@ -221,6 +226,9 @@ public function searchRuleAction()
 
             if (empty($interfaces)) {
                 $is_if = empty($record['interface']) || count(explode(',', $record['interface'])) > 1;
+            } elseif ((string)$record['interfacenot'] === "1") {
+                /* inverted interface acts as floating rule */
+                $is_if = true;
             } else {
                 $is_if = array_intersect(explode(',', $record['interface'] ?? ''), $interfaces);
                 $is_if = $is_if || empty($record['interface']);
@@ -481,8 +489,8 @@ public function getInterfaceListAction()
         foreach ((new \OPNsense\Firewall\Filter())->rules->rule->iterateItems() as $rule) {
             $interfaces = array_filter(explode(',', (string)$rule->interface));
 
-            if (count($interfaces) !== 1) {
-                // floating: empty or multiple interfaces
+            if ((string)$rule->interfacenot === "1" || count($interfaces) !== 1) {
+                // floating: empty, multiple, or inverted interface
                 $ruleCounts['floating'] = ($ruleCounts['floating'] ?? 0) + 1;
             } else {
                 // single interface

src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php

@@ -108,7 +108,11 @@ public function getPriority()
     {
         $configObj = Config::getInstance()->object();
         $interface = (string)$this->interface;
-        if (strpos($interface, ",") !== false || empty($interface)) {
+
+        if ((string)$this->interfacenot === "1" && !empty($interface)) {
+            // floating (inverted interface)
+            return 200000;
+        } elseif (strpos($interface, ",") !== false || empty($interface)) {
             // floating (multiple interfaces involved)
             return 200000;
         } elseif (