Custom card list screen : show response buttons and checkboxes only when all cards have been loaded (#7998)

[vlo-rte]

• In release notes :
  • In chapter : Features
  • Text : Custom card list screen : show response buttons and checkboxes only when all cards have been loaded #7998 : Custom card list screen : show response buttons and checkboxes only when all cards have been loaded

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request updates multiple aspects of the application’s UI and state management. In the CustomCardListComponent, modifications have been made to the HTML template to add a top margin for checkbox labels, introduce a conditional loading spinner with an accompanying tooltip, and wrap response buttons in a container that prevents interaction during loading. The corresponding SCSS file has updated spacing and height values for checkbox elements. In the TypeScript file, new imports are added, and a loadingInProgress boolean property is introduced, with its value managed via a debounced subscription to an event stream service. Additionally, the monitoring component’s styling has been adjusted by removing the old loading spinner styles and updating the copyright year, while a new global CSS class for a loading spinner has been added.

Possibly related PRs

• Custom card list screen : add lines per page choice for result table (#7925) #7991: Introduces pagination functionality and modifications to the CustomCardListComponent, aligning with the current changes in UI and state management.
• Custom card list screen : remove search button #7938: Modifies the CustomCardListComponent by removing a search button, indicating a direct relationship in the component’s updates.

Suggested reviewers

• ClementBouvierN

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fef955d and 9299f88.

📒 Files selected for processing (5)

• ui/main/src/app/components/customCardList/CustomCardListComponent.html (4 hunks)
• ui/main/src/app/components/customCardList/CustomCardListComponent.scss (1 hunks)
• ui/main/src/app/components/customCardList/CustomCardListComponent.ts (5 hunks)
• ui/main/src/app/components/monitoring/monitoring.component.scss (1 hunks)
• ui/main/src/scss/styles.scss (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• ui/main/src/app/components/monitoring/monitoring.component.scss

🔇 Additional comments (13)

ui/main/src/app/components/customCardList/CustomCardListComponent.ts (5)

13-13: LGTM: NgbPopover import added.

The NgbPopover import has been correctly added from @ng-bootstrap/ng-bootstrap to support the loading spinner tooltip.

---

33-34: Integration of loading state management.

Added OpfabEventStreamService for handling loading state events and debounceTime operator from rxjs to reduce excessive UI updates during loading state changes.

---

53-53: LGTM: NgbPopover registered in component imports.

Properly registered NgbPopover in the component imports array, ensuring the popover directives are available in the template.

---

123-123: LGTM: Added loading state property.

Added a loadingInProgress boolean property that will be used to control UI elements visibility.

---

133-137: LGTM: Well-implemented loading state subscription.

The implementation correctly:

• Subscribes to the loading state from OpfabEventStreamService
• Uses takeUntil for proper memory management and component lifecycle handling
• Applies debounceTime(500) to prevent rapid UI flickering during quick loading state changes

ui/main/src/app/components/customCardList/CustomCardListComponent.scss (1)

38-39: LGTM: Improved checkbox container styling.

The height property ensures consistent vertical space for the checkbox container, and the reduced margin-bottom provides better spacing with adjacent elements.

ui/main/src/scss/styles.scss (1)

724-732: LGTM: Well-defined loading spinner styling.

The new opfab-loading-spinner class is well-implemented with:

• Appropriate positioning (float: right with margin-right)
• Consistent sizing and styling
• Proper use of CSS variables for theme compatibility
• Clear visual indication with the gray text color (#aaa)

ui/main/src/app/components/customCardList/CustomCardListComponent.html (6)

78-78: LGTM: Improved checkbox label margin.

Adding margin-top: 10px to the label improves vertical alignment and spacing, creating a more balanced appearance.

---

89-89: LGTM: Consistent checkbox label margin.

Added consistent top margin to match the other checkbox, ensuring uniform appearance.

---

97-108: LGTM: Well-implemented loading spinner with tooltip.

The loading spinner implementation:

• Correctly shows only when loadingInProgress is true
• Uses auto margin-left to position it at the right side of the container
• Includes a helpful tooltip for improved user experience
• Properly uses ngbPopover with accessibility considerations

---

119-120: LGTM: Grid component conditional rendering.

The conditional rendering ensures that the appropriate grid version is shown based on loading state, with good use of Angular's ngIf/else pattern.

---

127-137: LGTM: Well-structured template for row selection.

The template implementation:

• Maintains all original grid properties and event handlers
• Properly applies row selection only when not in loading state
• Keeps the same styling and behavior as the original grid

---

166-175: LGTM: Effectively prevents interaction with response buttons during loading.

Wrapping the response buttons in a container that only renders when not loading:

• Prevents user interaction with response functionality during data loading
• Avoids potential issues with partial data selection
• Aligns with the PR objective to show response buttons only when all cards have been loaded

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud