Updated CORS Headers (#7985)

[ClementBouvierN]

Nothing in release note

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes involve modifying the Access-Control-Allow-Headers setting within the config/docker/nginx-cors-permissive.conf file. The configuration now specifies a defined list of headers—Authorization, Content-Type, X-Requested-With, Accept, Origin, X-CSRF-Token, and Cache-Control—instead of using the wildcard '*'. This update is implemented uniformly across various server block locations and routes, including /auth, /businessconfig, and /users, among others. There are no changes made to any exported or public entities.

Suggested reviewers

• freddidierRTE

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

config/docker/nginx-cors-permissive.conf (2)

35-35: Security improvement: Specified allowed CORS headers.

Replacing the wildcard '*' with a specific list of allowed headers is a good security practice that aligns with the principle of least privilege. This restricts which headers can be included in cross-origin requests, reducing the attack surface.

Consider also adding the Content-Length header to the allowed list, as it may be needed for certain API operations. While it's included in OPTIONS responses (line 46), clients might need to send it in actual requests.

---

45-45: Consistent CORS header configuration throughout the file.

The restricted header list has been consistently applied across all endpoints and request types. This ensures uniform security behavior throughout the application.

As a future enhancement, consider also restricting the other CORS headers that still use wildcards (Access-Control-Allow-Methods and Access-Control-Allow-Origin). Using specific values instead of wildcards would further improve security posture.

Also applies to: 55-55, 91-91, 120-120, 138-138, 161-161, 198-198, 219-219, 237-237, 255-255

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2695368 and 3f0fd9a.

📒 Files selected for processing (1)

• config/docker/nginx-cors-permissive.conf (11 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: build
• GitHub Check: build

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud