Skip to content

Add a lookbook example for loading inline macros#23876

Open
NobodysNightmare wants to merge 1 commit into
release/17.6from
loading-inline-macro
Open

Add a lookbook example for loading inline macros#23876
NobodysNightmare wants to merge 1 commit into
release/17.6from
loading-inline-macro

Conversation

@NobodysNightmare

Copy link
Copy Markdown
Contributor

We discussed this during a UX meeting today and it can't hurt to document this as a specific case, because we might have multiple implementations that need to behave like that.

Screenshot

image

We discussed this during a UX meeting today and it can't hurt to
document this as a specific case, because we might have multiple implementations
that need to behave like that.
@NobodysNightmare NobodysNightmare requested a review from HDinger June 23, 2026 08:39
@NobodysNightmare

Copy link
Copy Markdown
Contributor Author

Note that I am slightly surprised by the bad vertical alignment.

Though this seems to be large caused by the spinner itself being ill-aligned:

image

@Kharonus

Kharonus commented Jun 23, 2026

Copy link
Copy Markdown
Member

nice 🚀 can the vertical alignment get fixed?

@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/my_page/spec/features/my/work_package_table_spec.rb[1:1:1]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23876, linked for reference only):

- `rspec ./modules/my_page/spec/features/my/work_package_table_spec.rb[1:1:1]`

Treat this as a standalone task, unrelated to PR #23876. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23876 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @NobodysNightmare to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @NobodysNightmare, and request a review from @NobodysNightmare.
On every commit, set @NobodysNightmare as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants