Skip to content

Defer loading of page link inline macro#23847

Merged
NobodysNightmare merged 1 commit into
devfrom
defer-inline-macro-loading
Jun 24, 2026
Merged

Defer loading of page link inline macro#23847
NobodysNightmare merged 1 commit into
devfrom
defer-inline-macro-loading

Conversation

@NobodysNightmare

Copy link
Copy Markdown
Contributor

The main motivation for this is to not include user-specific information in the HTML-rendered formatted text of API responses, because we cache those responses across requests for different users.

This works around the caching issue by ensuring the relevant information is not part of the cache.

An alternative approach would be to ensure the caching is safe across different users.

Ticket

https://community.openproject.org/wp/XWI-125

@NobodysNightmare NobodysNightmare marked this pull request as draft June 22, 2026 14:51
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/backlogs/create_spec.rb[1:3:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23847, linked for reference only):

- `rspec ./modules/backlogs/spec/features/backlogs/create_spec.rb[1:3:2]`

Treat this as a standalone task, unrelated to PR #23847. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23847 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @NobodysNightmare to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @NobodysNightmare, and request a review from @NobodysNightmare.
On every commit, set @NobodysNightmare as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@NobodysNightmare NobodysNightmare force-pushed the defer-inline-macro-loading branch 2 times, most recently from 973a372 to dad9c42 Compare June 23, 2026 11:02
@NobodysNightmare NobodysNightmare requested a review from a team June 24, 2026 06:01
@NobodysNightmare NobodysNightmare marked this pull request as ready for review June 24, 2026 06:01
The main motivation for this is to not include user-specific information
in the HTML-rendered formatted text of API responses, because we cache those
responses across requests for different users.

This works around the caching issue by ensuring the relevant information is not
part of the cache.

An alternative approach would be to ensure the caching is safe across different
users.
@NobodysNightmare NobodysNightmare force-pushed the defer-inline-macro-loading branch from dad9c42 to bf57695 Compare June 24, 2026 07:52

@Kharonus Kharonus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a very much on point fix! GJ

@NobodysNightmare NobodysNightmare merged commit 715b54a into dev Jun 24, 2026
16 checks passed
@NobodysNightmare NobodysNightmare deleted the defer-inline-macro-loading branch June 24, 2026 13:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants