Defer loading of page link inline macro#23847
Merged
Merged
Conversation
|
Warning Flaky specs
🤖 Ask Copilot to investigateCopy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer. |
973a372 to
dad9c42
Compare
The main motivation for this is to not include user-specific information in the HTML-rendered formatted text of API responses, because we cache those responses across requests for different users. This works around the caching issue by ensuring the relevant information is not part of the cache. An alternative approach would be to ensure the caching is safe across different users.
dad9c42 to
bf57695
Compare
Kharonus
approved these changes
Jun 24, 2026
Kharonus
left a comment
Member
There was a problem hiding this comment.
Looks like a very much on point fix! GJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main motivation for this is to not include user-specific information in the HTML-rendered formatted text of API responses, because we cache those responses across requests for different users.
This works around the caching issue by ensuring the relevant information is not part of the cache.
An alternative approach would be to ensure the caching is safe across different users.
Ticket
https://community.openproject.org/wp/XWI-125