Skip to content

prevent failure in flaky spec reporting when running from external PR #23845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toy wants to merge 1 commit into
base: dev
Choose a base branch
from
+7 −1
Open

prevent failure in flaky spec reporting when running from external PR #23845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/test-core.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ jobs:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_AUTHOR: ${{ github.event.pull_request.user.login }}
PR_HEAD_REPO: ${{ github.event.pull_request.head.repo.full_name }}
run: |
if [ -f tmp/retried_specs.txt ]; then
echo "## Flaky specs" >> "$GITHUB_STEP_SUMMARY"
Expand All @@ -101,7 +102,12 @@ jobs:
SPECS="$(cat tmp/retried_specs.txt)" \
envsubst '$SPECS $PR_NUMBER $PR_AUTHOR' \
< .github/flaky-spec-copilot-comment.md > tmp/flaky_comment.md
gh pr comment "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --body-file tmp/flaky_comment.md
if [ "$PR_HEAD_REPO" != "$GITHUB_REPOSITORY" ]; then
echo "::warning::Flaky specs detected in this PR - see job summary for details"
cat tmp/flaky_comment.md
else
gh pr comment "$PR_NUMBER" --repo "$GITHUB_REPOSITORY" --body-file tmp/flaky_comment.md
fi
fi
fi
- name: Save CI image to cache
Expand Down
Loading