bug/69643 Documents: session/authentication error on page reload #21551
Conversation
| headers: { | ||
| Accept: 'text/vnd.turbo-stream.html', | ||
| 'X-Authentication-Scheme': 'Session', | ||
| }, |
There was a problem hiding this comment.
We should switch to using the central TurboRequestService, as it already has this special header + stream update functionality. I prefer to do this change later, on dev.
| // Delay setting connection error to avoid flickering on brief disconnects | ||
| setTimeout(() => { | ||
| setConnectionError(true); | ||
| }, 500); |
There was a problem hiding this comment.
I'm not entirely sure this timeout value will stick, or whether it's the best approach- oddly enough I was unable to reproduce the disconnect notice locally
There was a problem hiding this comment.
As discussed with @brunopagno, introducing an arbitrary delay opens the risk of losing data/content that is added within the delay period; we need a more complete solution that captures an intermediate reconnection/retry state before failure (connectionError) where the editor is potentially placed in a read-only state.
akabiru
force-pushed
the
bug/69643-documents-session-authentication-error-on-page-reload-on-firefox
branch
from
0721150 to
c95c9c5
Compare
|
Caution The provided work package version does not match the core version Details:
Please make sure that:
|
akabiru
deleted the
bug/69643-documents-session-authentication-error-on-page-reload-on-firefox
branch
Ticket
https://community.openproject.org/wp/69643
What are you trying to accomplish?
On reload, an error is swiftly shown on the page that collaboration is not working (although it disappears after the page is fully reloaded)bug/69643 Documents: session/authentication error on page reload #21551 (comment)Screenshots
What approach did you choose and why?
See: #18952
Merge checklist